build: update ruff and add lint-py-fix
#54410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
RedYetiDev
added
python
RedYetiDev
commented
Aug 16, 2024
tools/v8-json-to-junit.py
Outdated
There was a problem hiding this comment.
(Review note) Ref: astral-sh/ruff#12455
|
CC @nodejs/python |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54410 +/- ##
==========================================
- Coverage 88.06% 87.77% -0.29%
==========================================
Files 651 651
Lines 183538 183538
Branches 35862 35527 -335
==========================================
- Hits 161635 161109 -526
- Misses 15142 15678 +536
+ Partials 6761 6751 -10 |
cclauss
reviewed
Aug 16, 2024
RedYetiDev
added
the
commit-queue-squash
|
No objections in a week, how is everyone feeling about this? |
cclauss
requested changes
Aug 24, 2024
|
Its never ending... |
cclauss
approved these changes
Aug 24, 2024
|
Once this lands? Given that ruff keeps updating, another one shouldn't be opened until the next semver-minor, WDYT @cclauss P.S. can this land? |
|
(This modifies the Makefile, I don't know why I ever removed I've also requested a CI, hopefully that's okay. |
github-actions
bot
removed
the
request-ci
|
I know ruff 0.6.3 is out, but I don't think it's worth it to upgrade ruff again until the next semver-minor. |
|
@nodejs/python I have given this pull request a positive review and I think it should be merged but I am uncertain him to remove the Merging is blocked comment below. |
|
IIUC that notice is to prevent accidental merging from the GitHub UI (not the CQ) |
|
What is a |
|
Apologies, the Commit Queue |
This comment was marked as outdated.
This comment was marked as outdated.
RedYetiDev
removed
the
request-ci-failed
|
CI LGTM - The failure is related to an incident with github that has since been resolved. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
CI LGTM |
|
CI is passing, can this land? |
|
Ruff is currently at 0.6.7, however, this has a passing CI, and ruff get's updated all the time. For that reason, I'm not updating ruff again. IMO it can be done once v0.7 is released. |
This comment has been minimized.
This comment has been minimized.
H4ad
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54410 ✔ Done loading data for nodejs/node/pull/54410 ----------------------------------- PR info ------------------------------------ Title build: update ruff and add `lint-py-fix` (#54410) Author Aviv Keller <[email protected]> (@RedYetiDev) Branch RedYetiDev:ruff-0.6.0 -> nodejs:main Labels build, python, author ready, needs-ci, commit-queue-squash Commits 1 - build: update ruff and add `lint-py-fix` Committers 1 - RedYetiDev <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54410 Reviewed-By: Christian Clauss <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54410 Reviewed-By: Christian Clauss <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - build: update ruff and add `lint-py-fix` ℹ This PR was created on Fri, 16 Aug 2024 16:57:16 GMT ✔ Approvals: 1 ✔ - Christian Clauss (@cclauss): https://github.com/nodejs/node/pull/54410#pullrequestreview-2258871347 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-21T16:23:14Z: https://ci.nodejs.org/job/node-test-pull-request/62637/ - Querying data for job/node-test-pull-request/62637/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11001786432 |
|
(Sorry for the ping, rerequesting review so this can land) |
cclauss
approved these changes
Sep 24, 2024
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a1cd3c8 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54410 Reviewed-By: Christian Clauss <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54410 Reviewed-By: Christian Clauss <[email protected]>
marco-ippolito
added
the
backport-requested-v20.x
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#54410 Reviewed-By: Christian Clauss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
ruffto 0.6.5, and adds two new makefile targets:lint-py-fixlint-py-fix-unsafe