src: replace deprecated v8::FastApiTypedArray
#54103
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
|
I'm not sure about the changes here, but I can update the other uses if they are correct. |
ronag
reviewed
Jul 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54103 +/- ##
==========================================
- Coverage 87.07% 87.07% -0.01%
==========================================
Files 643 643
Lines 181583 181587 +4
Branches 34886 34887 +1
==========================================
- Hits 158114 158109 -5
+ Misses 16751 16748 -3
- Partials 6718 6730 +12
|
|
Seems significantly slower. I would propose we stick with the deprecated api until there is a faster alternative or until it's been removed. |
|
I had similar results with the copy pr |
anonrig
reviewed
Jul 29, 2024
| @@ -1129,14 +1129,16 @@ void SlowIndexOfNumber(const FunctionCallbackInfo<Value>& args) { | |||
| } | |||
|
|
|||
| int32_t FastIndexOfNumber(v8::Local<v8::Value>, | |||
| const FastApiTypedArray<uint8_t>& buffer, | |||
| v8::Local<v8::Object> buffer, | |||
There was a problem hiding this comment.
This is actually slower in V8 v12.8 (by a significant margin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5691777