-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: correct typescript stdin support #54036
doc: correct typescript stdin support #54036
Conversation
Fast-track has been requested by @marco-ippolito. Please 👍 to approve. |
we definitely need to add this doc under some codeowner cc @nodejs/loaders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, but why would it work for eval and not STDIN? We usually treat those as equivalent.
It has not been implemented or tested, it has to be done, so pr welcome 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Landed in 2cd9687 |
PR-URL: #54036 Fixes: #54035 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #54036 Fixes: #54035 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
STDIN was never meant to be supported initally, so the documentation is incorrect.
Fixes: #54035