-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: specify that preloaded modules affect subprocesses #52939
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tim Fish <[email protected]>
nodejs-github-bot
added
cli
Issues and PRs related to the Node.js command line interface.
doc
Issues and PRs related to the documentations.
labels
May 10, 2024
Hey, this hasn't seen any reviews or objections, just bumping it a bit. |
jasnell
approved these changes
Aug 11, 2024
@jasnell I think this is good to land? |
Trott
approved these changes
Sep 4, 2024
Trott
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 4, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 4, 2024
Landed in 2bd6a57 |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
Co-Authored-By: Tim Fish <[email protected]> PR-URL: #52939 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
targos
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
Sep 22, 2024
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Co-Authored-By: Tim Fish <[email protected]> PR-URL: nodejs#52939 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
Co-Authored-By: Tim Fish <[email protected]> PR-URL: nodejs#52939 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cli
Issues and PRs related to the Node.js command line interface.
doc
Issues and PRs related to the documentations.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
loaders
Issues and PRs related to ES module loaders
review wanted
PRs that need reviews.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52930
Marking author as
Co-Author
, as they specified where the preloaded modules will appear.