Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps, src: simplifying base64 encoding #52714

Merged
merged 2 commits into from
Apr 30, 2024
Merged

deps, src: simplifying base64 encoding #52714

merged 2 commits into from
Apr 30, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented Apr 26, 2024 •
edited
Loading

Following recent work by @anonrig, we no longer have use for existing base64 encoding code. This PR, if merged, will drop much of the base64 encoding code.

It should be otherwise inconsequential.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg

@lemire lemire requested a review from anonrig April 26, 2024 19:15
@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Apr 26, 2024
@lemire lemire force-pushed the simplifying_base64_encoding branch 2 times, most recently from 280494e to 8297c11 Compare April 26, 2024 19:40
@richardlau richardlau added the baking-for-lts PRs that need to wait before landing in a LTS release. label Apr 26, 2024
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58733/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58737/

@marco-ippolito marco-ippolito removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2024
@meyfa
Copy link
Contributor

meyfa commented Apr 27, 2024

Awesome!

Nit: I think the commit message needs to be amended to start with an imperative verb, according to the guidelines.

@lemire lemire force-pushed the simplifying_base64_encoding branch from 842e9e1 to 7a07c7e Compare April 27, 2024 15:31
@lemire
Copy link
Member Author

lemire commented Apr 27, 2024

Nit: I think the commit message needs to be amended to start with an imperative verb, according to the guidelines.

Fixed.

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2024
MoLow
MoLow approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
nice

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58770/

targos
targos requested changes Apr 28, 2024
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run tools/license-builder.sh to update the license

@lemire
Copy link
Member Author

lemire commented Apr 29, 2024

@targos Good catch! Ran it.

@lemire lemire mentioned this pull request Apr 29, 2024
Closed
@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58800/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58812/

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 30, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 30, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6aa9047 into nodejs:main Apr 30, 2024
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6aa9047

aduh95 pushed a commit that referenced this pull request Apr 30, 2024
@lemire @aduh95
deps,src: simplify base64 encoding
8e4fd28 
PR-URL: #52714
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@aduh95 aduh95 mentioned this pull request Apr 30, 2024
Merged
@zcbenz zcbenz mentioned this pull request May 6, 2024
Merged
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@lemire
deps,src: simplify base64 encoding
92483b0 
PR-URL: nodejs#52714
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@lemire lemire mentioned this pull request Jun 12, 2024
Open
richardlau added a commit to richardlau/node-1 that referenced this pull request Jun 13, 2024
@richardlau
src: remove base64 from process.versions
b06b82f 
The `base64` dependency was previously removed along with the update
script (`tools/dep_updaters/update-base64.sh`) but the generated header,
`src/base64_version.h` was left behind and `process.versions` was still
listing the last version of `base64` that was included in Node.js before
it was removed

Refs: nodejs#52714
@richardlau richardlau mentioned this pull request Jun 13, 2024
Merged
@richardlau
Copy link
Member

When this lands in LTS, it should land with the fixup for process.versions: #53442.

nodejs-github-bot pushed a commit that referenced this pull request Jun 15, 2024
@richardlau
src: remove base64 from process.versions
9351425 
The `base64` dependency was previously removed along with the update
script (`tools/dep_updaters/update-base64.sh`) but the generated header,
`src/base64_version.h` was left behind and `process.versions` was still
listing the last version of `base64` that was included in Node.js before
it was removed

Refs: #52714
PR-URL: #53442
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
targos pushed a commit that referenced this pull request Jun 20, 2024
@richardlau @targos
src: remove base64 from process.versions
5961253 
The `base64` dependency was previously removed along with the update
script (`tools/dep_updaters/update-base64.sh`) but the generated header,
`src/base64_version.h` was left behind and `process.versions` was still
listing the last version of `base64` that was included in Node.js before
it was removed

Refs: #52714
PR-URL: #53442
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
EliphazBouye pushed a commit to EliphazBouye/node that referenced this pull request Jun 20, 2024
@lemire @EliphazBouye
deps,src: simplify base64 encoding
42a18f3 
PR-URL: nodejs#52714
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
EliphazBouye pushed a commit to EliphazBouye/node that referenced this pull request Jun 20, 2024
@richardlau @EliphazBouye
src: remove base64 from process.versions
11b7b35 
The `base64` dependency was previously removed along with the update
script (`tools/dep_updaters/update-base64.sh`) but the generated header,
`src/base64_version.h` was left behind and `process.versions` was still
listing the last version of `base64` that was included in Node.js before
it was removed

Refs: nodejs#52714
PR-URL: nodejs#53442
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@lemire @bmeck
deps,src: simplify base64 encoding
a711a33 
PR-URL: nodejs#52714
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@richardlau @bmeck
src: remove base64 from process.versions
a896f14 
The `base64` dependency was previously removed along with the update
script (`tools/dep_updaters/update-base64.sh`) but the generated header,
`src/base64_version.h` was left behind and `process.versions` was still
listing the last version of `base64` that was included in Node.js before
it was removed

Refs: nodejs#52714
PR-URL: nodejs#53442
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@aduh95 aduh95 removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@MoLow MoLow MoLow approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@lemire @nodejs-github-bot @meyfa @richardlau @anonrig @targos @MoLow @BridgeAR @marco-ippolito @aduh95