node-api: address coverity report #52584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address missing initialization reported by coverity Signed-off-by: Michael Dawson <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
c++
|
Report from coverity class ExternalWrapper {
835 private:
2. uninit_member: Non-static class member type_tag_.lower is not initialized in this constructor nor in any functions that it calls.
CID 361482: (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member type_tag_.upper is not initialized in this constructor nor in any functions that it calls.
836 explicit ExternalWrapper(void* data) : data_(data) {}
837
838 static void WeakCallback(const v8::WeakCallbackInfo<ExternalWrapper>& data) {
839 ExternalWrapper* wrapper = data.GetParameter();
840 delete wrapper;
841 } |
|
It is a good fix. Though in this code we must not be affected by the not-initialized variable because it is guarded by the Boolean flag |
legendecas
approved these changes
Apr 19, 2024
gabrielschulhof
approved these changes
Apr 19, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
approved these changes
Apr 22, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e4c1d02 |
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
Address missing initialization reported by coverity Signed-off-by: Michael Dawson <[email protected]> PR-URL: #52584 Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
Address missing initialization reported by coverity Signed-off-by: Michael Dawson <[email protected]> PR-URL: #52584 Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
Address missing initialization reported by coverity Signed-off-by: Michael Dawson <[email protected]> PR-URL: #52584 Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
EliphazBouye
pushed a commit
to EliphazBouye/node
that referenced
this pull request
Jun 20, 2024
Address missing initialization reported by coverity Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#52584 Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Address missing initialization reported by coverity Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#52584 Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address missing initialization reported by coverity