Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use predefined variable instead of bit operation #52580

Merged
merged 1 commit into from
Apr 20, 2024
Merged

lib: use predefined variable instead of bit operation #52580

merged 1 commit into from
Apr 20, 2024

Conversation

deokjinkim
Copy link
Contributor

node/lib/internal/validators.js

Lines 225 to 226 in 3790d52

const kValidateObjectAllowObjects = kValidateObjectAllowArray |
kValidateObjectAllowFunction;

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 18, 2024
@deokjinkim deokjinkim added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58510/

@deokjinkim deokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit f7a9cdc into nodejs:main Apr 20, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f7a9cdc

aduh95 pushed a commit that referenced this pull request Apr 29, 2024
@deokjinkim @aduh95
lib: use predefined variable instead of bit operation
9ffdcad 
PR-URL: #52580
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95 aduh95 mentioned this pull request Apr 30, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@deokjinkim @marco-ippolito
lib: use predefined variable instead of bit operation
518d41b 
PR-URL: #52580
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@deokjinkim @marco-ippolito
lib: use predefined variable instead of bit operation
acd7758 
PR-URL: #52580
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@daeyeon daeyeon daeyeon approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deokjinkim @nodejs-github-bot @benjamingr @lpinca @daeyeon @VoltrexKeyva