Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix buffer[index] example #5253

Closed
wants to merge 2 commits into from
Closed

doc: fix buffer[index] example #5253

wants to merge 2 commits into from

Conversation

chinedufn
Copy link
Contributor

No description provided.

@mscdex mscdex added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Feb 16, 2016
@thefourtheye
Copy link
Contributor

LGTM cc @trevnorris

targos
targos reviewed Feb 16, 2016
View reviewed changes
doc/api/buffer.markdown
@@ -351,7 +351,7 @@ for (var i = 0; i < str.length ; i++) {
buf[i] = str.charCodeAt(i);
}

console.log(buf);
console.log(buf.toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example states it is an ASCII string. I would be explicit and write buf.toString('ascii').

@targos
Copy link
Member

targos commented Feb 16, 2016

LGTM with a suggestion

@chinedufn
Copy link
Contributor Author

@targos thanks for the suggestion! Pushed

@jasnell
Copy link
Member

jasnell commented Feb 16, 2016

LGTM

@silverwind
Copy link
Contributor

Thanks! Landed in 069072c.

silverwind pushed a commit that referenced this pull request Feb 18, 2016
@chinedufn @silverwind
doc: fix buffer[index] example
069072c 
PR-URL: #5253
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@silverwind silverwind closed this Feb 18, 2016
rvagg pushed a commit that referenced this pull request Feb 18, 2016
@chinedufn @rvagg
doc: fix buffer[index] example
a6e437c 
PR-URL: #5253
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
@chinedufn
doc: fix buffer[index] example
ffb6e6a 
PR-URL: #5253
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
@chinedufn
doc: fix buffer[index] example
6c27c78 
PR-URL: #5253
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@chinedufn
doc: fix buffer[index] example
59e55ae 
PR-URL: #5253
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chinedufn @thefourtheye @targos @jasnell @silverwind @mscdex @MylesBorins