tools: fix eslint update script #52526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
targos
reviewed
Apr 14, 2024
| @@ -58,6 +58,7 @@ rm -rf ../node_modules/eslint | |||
| --no-save \ | |||
| --omit=dev \ | |||
| --omit=peer \ | |||
| --legacy-peer-deps \ | |||
There was a problem hiding this comment.
I'd prefer to wait for plugins to officially support ESLint v9.
There was a problem hiding this comment.
Here's the PR that adds support to babel-eslint: babel/babel#16414
There was a problem hiding this comment.
Ok so I'll set it as blocked until that pr lands? or I can just close it
There was a problem hiding this comment.
#50714 is not directly related but I would like to land it before we do a new automated update.
|
Also note that ESLint v9 has breaking changes related to the configuration and will need to be manually upgraded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #52521
Test with: #52525
RUN: https://github.com/nodejs/node/actions/runs/8679237634 ✅
Blocked by #50714 and untill plugins support eslint v9