Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add Rafael to steward list #52452

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

RafaelGSS
Copy link
Member

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 10, 2024
@RafaelGSS RafaelGSS added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 10, 2024
Copy link
Contributor

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 10, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/52452
✔  Done loading data for nodejs/node/pull/52452
----------------------------------- PR info ------------------------------------
Title      doc: add Rafael to steward list (#52452)
Author     Rafael Gonzaga  (@RafaelGSS)
Branch     RafaelGSS:add-rafael-steward-april10 -> nodejs:main
Labels     doc, fast-track
Commits    1
 - doc: add Rafael to steward list
Committers 1
 - RafaelGSS 
PR-URL: https://github.com/nodejs/node/pull/52452
Refs: https://github.com/nodejs-private/security-release/issues/22
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Moshe Atlow 
Reviewed-By: Richard Lau 
Reviewed-By: Vinícius Lourenço Claro Cardoso 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52452
Refs: https://github.com/nodejs-private/security-release/issues/22
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Moshe Atlow 
Reviewed-By: Richard Lau 
Reviewed-By: Vinícius Lourenço Claro Cardoso 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 10 Apr 2024 17:02:06 GMT
   ✔  Approvals: 4
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/52452#pullrequestreview-1992355019
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52452#pullrequestreview-1992371968
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/52452#pullrequestreview-1992392097
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52452#pullrequestreview-1992582811
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 44 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/8637443818

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit b4186ec into nodejs:main Apr 10, 2024
29 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b4186ec

marco-ippolito pushed a commit that referenced this pull request May 2, 2024
PR-URL: #52452
Refs: nodejs-private/security-release#22
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
PR-URL: #52452
Refs: nodejs-private/security-release#22
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants