test: fix Windows compiler warnings in overlapped-checker #52405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
richardlau
approved these changes
Apr 7, 2024
VoltrexKeyva
approved these changes
Apr 7, 2024
anonrig
approved these changes
Apr 7, 2024
StefanStojanovic
approved these changes
Apr 7, 2024
Fixes two warnings: - test\overlapped-checker\main_win.c(37,25): warning : format specifies type 'int' but the argument has type 'DWORD' (aka 'unsigned long') [-Wformat] - test\overlapped-checker\main_win.c(9,14): warning : unused variable 'write_count' [-Wunused-variable]
|
Fixed the format of the commit message. |
github-actions
bot
removed
the
request-ci
|
This needs a new review to land. |
richardlau
approved these changes
Apr 10, 2024
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in eb53121 |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
Fixes two warnings: - test\overlapped-checker\main_win.c(37,25): warning : format specifies type 'int' but the argument has type 'DWORD' (aka 'unsigned long') [-Wformat] - test\overlapped-checker\main_win.c(9,14): warning : unused variable 'write_count' [-Wunused-variable] PR-URL: #52405 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
Fixes two warnings: - test\overlapped-checker\main_win.c(37,25): warning : format specifies type 'int' but the argument has type 'DWORD' (aka 'unsigned long') [-Wformat] - test\overlapped-checker\main_win.c(9,14): warning : unused variable 'write_count' [-Wunused-variable] PR-URL: #52405 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two warnings:
test\overlapped-checker\main_win.c(37,25): warning : format specifies type 'int' but the argument has type 'DWORD' (aka 'unsigned long') [-Wformat]test\overlapped-checker\main_win.c(9,14): warning : unused variable 'write_count' [-Wunused-variable]