src: stop using v8::BackingStore::Reallocate
#52292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
joyeecheung
reviewed
Mar 31, 2024
There was a problem hiding this comment.
Some suggestions to avoid the copy when the size is the same.
(I do wonder now that we can't shrink the backing store in place, is there any benefit in allocating them on the V8 heap instead of using externally-managed buffers that we can realloc()? At least when we shrink externally-managed buffers we don't need to do the copy and it'll be cheaper. But that can be left as a TODO after we get rid of the deprecated API).
|
Updated! |
|
Something's wrong with the new changes. |
It's being deprecated by V8. Explicitly allocate a new ArrayBuffer and copy the data when needed instead. Fixes: nodejs#52234 Co-authored-by: Joyee Cheung <[email protected]>
github-actions
bot
removed
the
request-ci
addaleax
approved these changes
Apr 2, 2024
tniessen
approved these changes
Apr 2, 2024
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ec15504 |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
It's being deprecated by V8. Explicitly allocate a new ArrayBuffer and copy the data when needed instead. Fixes: #52234 Co-authored-by: Joyee Cheung <[email protected]> PR-URL: #52292 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
It's being deprecated by V8. Explicitly allocate a new ArrayBuffer and copy the data when needed instead. Fixes: #52234 Co-authored-by: Joyee Cheung <[email protected]> PR-URL: #52292 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's being deprecated by V8.
Explicitly allocate a new ArrayBuffer and copy the data instead.
Fixes: #52234