Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: allow local updates for llhttp #52085

Merged
merged 2 commits into from
Mar 30, 2024
Merged

tools: allow local updates for llhttp #52085

merged 2 commits into from
Mar 30, 2024

Conversation

ShogunPanda
Copy link
Contributor

This PR allows to specify a local folder to update llhttp.

This is especially beneficial in security releases.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 14, 2024
mhdawson
mhdawson approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mertcanaltin
mertcanaltin approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 30, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/52085
✔  Done loading data for nodejs/node/pull/52085
----------------------------------- PR info ------------------------------------
Title      tools: allow local updates for llhttp (#52085)
Author     Paolo Insogna  (@ShogunPanda)
Branch     ShogunPanda:local-llhttp-update -> nodejs:main
Labels     tools
Commits    2
 - tools: allow local updates for llhttp
 - tools: linted code
Committers 1
 - Paolo Insogna 
PR-URL: https://github.com/nodejs/node/pull/52085
Reviewed-By: Michael Dawson 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Marco Ippolito 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52085
Reviewed-By: Michael Dawson 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Marco Ippolito 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 14 Mar 2024 15:50:21 GMT
   ✔  Approvals: 3
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/52085#pullrequestreview-1943813612
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/52085#pullrequestreview-1945936095
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/52085#pullrequestreview-1969860145
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 52085
From https://github.com/nodejs/node
 * branch                  refs/pull/52085/merge -> FETCH_HEAD
✔  Fetched commits as 7c02486f1f91..c08c98b4692d
--------------------------------------------------------------------------------
[main 6dcecc3b9a] tools: allow local updates for llhttp
 Author: Paolo Insogna 
 Date: Thu Mar 14 16:48:20 2024 +0100
 1 file changed, 29 insertions(+), 12 deletions(-)
[main a4cc53b0e6] tools: linted code
 Author: Paolo Insogna 
 Date: Fri Mar 15 08:18:57 2024 +0100
 2 files changed, 6 insertions(+), 5 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

tools: allow local updates for llhttp


PR-URL: #52085

Reviewed-By: Michael Dawson [email protected]

Reviewed-By: Rafael Gonzaga [email protected]

Reviewed-By: Marco Ippolito [email protected]


[detached HEAD 9d82a25db1] tools: allow local updates for llhttp

Author: Paolo Insogna [email protected]

Date: Thu Mar 14 16:48:20 2024 +0100

1 file changed, 29 insertions(+), 12 deletions(-)

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

tools: linted code


PR-URL: #52085

Reviewed-By: Michael Dawson [email protected]

Reviewed-By: Rafael Gonzaga [email protected]

Reviewed-By: Marco Ippolito [email protected]


[detached HEAD 8d640cbd0b] tools: linted code

Author: Paolo Insogna [email protected]

Date: Fri Mar 15 08:18:57 2024 +0100

2 files changed, 6 insertions(+), 5 deletions(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/8489560058

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 30, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2024
@nodejs-github-bot nodejs-github-bot merged commit 021cf91 into nodejs:main Mar 30, 2024
28 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 021cf91

@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@ShogunPanda @marco-ippolito
tools: allow local updates for llhttp
423835c 
PR-URL: #52085
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@ShogunPanda @marco-ippolito
tools: allow local updates for llhttp
c7238d0 
PR-URL: #52085
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@ShogunPanda ShogunPanda deleted the local-llhttp-update branch July 29, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ShogunPanda @nodejs-github-bot @mhdawson @RafaelGSS @marco-ippolito @mertcanaltin