doc: remove ArrayBuffer from crypto.hash() data parameter type #52069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
crypto
aduh95
added
fast-track
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
marco-ippolito
approved these changes
Mar 13, 2024
legendecas
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
LGTM.
BTW, would you mind updating the typo algorith with algorithm on the line 3513 as well?
fengmk2
force-pushed
the
typo-fix-on-crypto
branch
from
d183ea8
to
142b654
Compare
|
@legendecas done |
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 57d2e48 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
PR-URL: nodejs#52069 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52069 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52069 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
jcbhmr
pushed a commit
to jcbhmr/node
that referenced
this pull request
May 15, 2024
PR-URL: nodejs#52069 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.