Feature/update cares to 4ef6817c76dcae00edc131ed966f580db1c5ee8f #5199
Conversation
PR-URL: nodejs#5090 Reviewed-By: Fedor Indutny <[email protected]>
|
LGTM |
mscdex
added
c++
|
All green. LGTM. |
|
Thank you so much @jbergstroem and @thealphanerd ! @bnoordhuis PTAL, I need your LGTM as well. |
|
LGTM It may still make sense to revert the c-ares upgrade in the v5.x branch because we're basically shipping their tip-of-master. I infer from the brand new |
|
@bnoordhuis ok, this is what I wanted to hear. May I ask you to do a revert? This way it will look like your decision and we will all blame you eventually 😉 |
|
Thanks! |
|
Haha, okay. I'm off to bed now but I'll open a pull request for that tomorrow. |
PR-URL: #5199 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
|
Landed in cc192f0, and 72c5458. Btw, cfafba6 is no longer needed as it has landed upstream! Thank you everyone! |
indutny
deleted the
feature/update-cares-to-4ef6817c76dcae00edc131ed966f580db1c5ee8f
branch
|
@indutny @bnoordhuis ... I'm assume this is not something we'd want in v4? |
|
@jasnell afaik the other cares update was not backported |
|
@jasnell nope, we don't want it. Let's play double-safe in v4, and just safe in v5 :) |
PR-URL: #5199 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
This reverts commit 35c3832. See [0] and [1] for background. Let's hold off on upgrading c-ares until upstream makes an official release. [0] nodejs#5185 [1] nodejs#5199 PR-URL: nodejs#5199 Reviewed-By: Fedor Indutny <[email protected]>
|
Marking as |
PR-URL: nodejs#5199 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
R= @bnoordhuis
Fix: #5185