test: fix unreliable assumption in js-native-api/test_cannot_run_js

test/js-native-api/test_cannot_run_js/test_cannot_run_js.c

@@ -6,17 +6,33 @@
 static void Finalize(napi_env env, void* data, void* hint) {
   napi_value global, set_timeout;
   napi_ref* ref = data;
+
+  NODE_API_NOGC_ASSERT_RETURN_VOID(
+      napi_delete_reference(env, *ref) == napi_ok,
+      "deleting reference in finalizer should succeed");
+  NODE_API_NOGC_ASSERT_RETURN_VOID(
+      napi_get_global(env, &global) == napi_ok,
+      "getting global reference in finalizer should succeed");
+  napi_status result =
+      napi_get_named_property(env, global, "setTimeout", &set_timeout);
+
+  // The finalizer could be invoked either from check callbacks (as native
+  // immediates) if the event loop is still running (where napi_ok is returned)
+  // or during environment shutdown (where napi_cannot_run_js or
+  // napi_pending_exception is returned). This is not deterministic from
+  // the point of view of the addon.
+
 #ifdef NAPI_EXPERIMENTAL
-  napi_status expected_status = napi_cannot_run_js;
+  NODE_API_NOGC_ASSERT_RETURN_VOID(
+      result == napi_cannot_run_js || result == napi_ok,
+      "getting named property from global in finalizer should succeed "
+      "or return napi_cannot_run_js");
 #else
-  napi_status expected_status = napi_pending_exception;
+  NODE_API_NOGC_ASSERT_RETURN_VOID(
+      result == napi_pending_exception || result == napi_ok,
+      "getting named property from global in finalizer should succeed "
+      "or return napi_pending_exception");
 #endif  // NAPI_EXPERIMENTAL
-
-  if (napi_delete_reference(env, *ref) != napi_ok) abort();
-  if (napi_get_global(env, &global) != napi_ok) abort();
-  if (napi_get_named_property(env, global, "setTimeout", &set_timeout) !=
-      expected_status)
-    abort();
   free(ref);
 }
 

test/root.status

@@ -1,5 +1,4 @@
 [true]
-js-native-api/test_cannot_run_js/test: PASS,FLAKY
 
 [$mode==debug]
 async-hooks/test-callback-error: SLOW