Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,doc: fix linting errors #5161

Closed
wants to merge 1 commit into from
Closed

tools,doc: fix linting errors #5161

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 9, 2016

We recently added linting for files in tools/doc but PR #4741 was submitted before that tooling was added. It landed without a rebase and test run, so it's breaking CI. This fixes the minor lint issues. Hopefully this can land quickly.

/cc @fansworld-claudio @silverwind

Refs: #4741 (comment)

@Trott Trott added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. lts-watch-v4.x labels Feb 9, 2016
@silverwind
Copy link
Contributor

FYI from the CI:

/usr/home/iojs/build/workspace/node-test-linter/tools/doc/type-parser.js
   9:2   error  Missing semicolon                                   semi
  31:19  error  Unexpected space before function parentheses        space-before-function-paren
  32:9   error  `typeLinks` is never modified, use `const` instead  prefer-const
  34:9   error  `typeTexts` is never modified, use `const` instead  prefer-const
  36:31  error  Unexpected space before function parentheses        space-before-function-paren
  59:2   error  Missing semicolon                                   semi

LGTM

shipit

@silverwind
Copy link
Contributor

Also, CI: https://ci.nodejs.org/job/node-test-pull-request/1608/

@Trott
Copy link
Member Author

Trott commented Feb 9, 2016

Fire drill. I'm not even joking. Feel free to land. I'll be gone for a while.

@MylesBorins
Copy link
Contributor

LGTM if CI is good

@silverwind silverwind self-assigned this Feb 9, 2016
silverwind pushed a commit that referenced this pull request Feb 9, 2016
@Trott @silverwind
tools,doc: fix linting errors
1693349 
Refs: #4741 (comment)
PR-URL: #5161
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@silverwind
Copy link
Contributor

Linter on CI is green. Landed in 1693349. Thanks again for finding it so quickly, @Trott.

@silverwind silverwind closed this Feb 9, 2016
@claudiorodriguez
Copy link
Contributor

Thanks for this!

rvagg pushed a commit that referenced this pull request Feb 10, 2016
@Trott @rvagg
tools,doc: fix linting errors
bcc26f7 
Refs: #4741 (comment)
PR-URL: #5161
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@bnoordhuis bnoordhuis mentioned this pull request Feb 10, 2016
Closed
@MylesBorins
Copy link
Contributor

type parser does not exist on v4.x

@silverwind
Copy link
Contributor

This depends on #4741.

@MylesBorins
Copy link
Contributor

thanks @silverwind updated labels

MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
@Trott
tools,doc: fix linting errors
d4385c0 
Refs: #4741 (comment)
PR-URL: #5161
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
@Trott
tools,doc: fix linting errors
0100639 
Refs: #4741 (comment)
PR-URL: #5161
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@Trott
tools,doc: fix linting errors
7c1cd9a 
Refs: #4741 (comment)
PR-URL: #5161
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@Trott Trott deleted the lintdoc branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@silverwind silverwind

Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @silverwind @MylesBorins @claudiorodriguez