test: disable gh-5100 test when in FIPS mode #5144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up fix for half-broken test in 23196fe, and an attempt to recover some dignity after breaking CI.
|
LGTM if CI is OK |
|
@Trott I'm going to be off for a bit, so if you will notice that it is green earlier than I will do - feel free to land this. Thanks! |
mscdex
added
test
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Feb 8, 2016
This is a follow-up fix for half-broken test in 23196fe, and an attempt to recover some dignity after breaking CI. PR-URL: nodejs#5144 Reviewed-By: Rich Trott <[email protected]>
|
Landed in c64d051 |
|
It was my regrettable review to have missed to run CI and checked FIPS compliance. The FIPS error comes from certificate is encrypted by RC2 and it can be resolved by the option of shigeki@4029465 and https://ci.nodejs.org/job/node-test-commit-linux-fips/869/ shows it works fine. |
|
@shigeki great! Let's file a PR for this. |
shigeki
pushed a commit
to shigeki/node
that referenced
this pull request
Feb 9, 2016
The pfx file created by pkcs12 command of openssl causes an error in FIPS mode because its certificate is encrypted with RC2 by default. Adding `-descert` option resolves the error. Fix: nodejs#5144 Fix: nodejs#5109
shigeki
pushed a commit
that referenced
this pull request
Feb 9, 2016
The pfx file created by pkcs12 command of openssl causes an error in FIPS mode because its certificate is encrypted with RC2 by default. Adding `-descert` option resolves the error. Fix: #5144 Fix: #5109 PR-URL: #5150 Reviewed-By: Rich Trott <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 9, 2016
This is a follow-up fix for half-broken test in 23196fe, and an attempt to recover some dignity after breaking CI. PR-URL: #5144 Reviewed-By: Rich Trott <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 9, 2016
The pfx file created by pkcs12 command of openssl causes an error in FIPS mode because its certificate is encrypted with RC2 by default. Adding `-descert` option resolves the error. Fix: #5144 Fix: #5109 PR-URL: #5150 Reviewed-By: Rich Trott <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 9, 2016
This is a follow-up fix for half-broken test in 23196fe, and an attempt to recover some dignity after breaking CI. PR-URL: #5144 Reviewed-By: Rich Trott <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 9, 2016
The pfx file created by pkcs12 command of openssl causes an error in FIPS mode because its certificate is encrypted with RC2 by default. Adding `-descert` option resolves the error. Fix: #5144 Fix: #5109 PR-URL: #5150 Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
This is a follow-up fix for half-broken test in 23196fe, and an attempt to recover some dignity after breaking CI. PR-URL: #5144 Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
The pfx file created by pkcs12 command of openssl causes an error in FIPS mode because its certificate is encrypted with RC2 by default. Adding `-descert` option resolves the error. Fix: #5144 Fix: #5109 PR-URL: #5150 Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
This is a follow-up fix for half-broken test in 23196fe, and an attempt to recover some dignity after breaking CI. PR-URL: #5144 Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
The pfx file created by pkcs12 command of openssl causes an error in FIPS mode because its certificate is encrypted with RC2 by default. Adding `-descert` option resolves the error. Fix: #5144 Fix: #5109 PR-URL: #5150 Reviewed-By: Rich Trott <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
This is a follow-up fix for half-broken test in 23196fe, and an attempt to recover some dignity after breaking CI. PR-URL: #5144 Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
The pfx file created by pkcs12 command of openssl causes an error in FIPS mode because its certificate is encrypted with RC2 by default. Adding `-descert` option resolves the error. Fix: #5144 Fix: #5109 PR-URL: #5150 Reviewed-By: Rich Trott <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
This is a follow-up fix for half-broken test in 23196fe, and an attempt to recover some dignity after breaking CI. PR-URL: nodejs#5144 Reviewed-By: Rich Trott <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
The pfx file created by pkcs12 command of openssl causes an error in FIPS mode because its certificate is encrypted with RC2 by default. Adding `-descert` option resolves the error. Fix: nodejs#5144 Fix: nodejs#5109 PR-URL: nodejs#5150 Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up fix for half-broken test in 23196fe, and an attempt
to recover some dignity after breaking CI.
cc @Trott