test_runner: fix after hook inside test suite is not executed if before() throws an error

[pulkit-30]

fix #50842

fix code:

import { it, before, describe, after } from 'node:test';

describe('failing test suite', () => {
  before(async () => {
    console.log('before called');
    throw new Error('error');
  });

  after(async () => {
    console.log('after called');
  });

  it('should be ok', async () => {});
});

pulkitgupta@Pulkits-MacBook-Air node % ./node index.mjs
before called
+ after called
▶ failing test suite
  ✖ should be ok
    'test did not finish before its parent and was cancelled'

▶ failing test suite (3.217584ms)

  Error: error
      at SuiteContext.<anonymous> (file:///Users/pulkitgupta/Desktop/node/index.mjs:6:11)
      at TestHook.runInAsyncScope (node:async_hooks:206:9)
      at TestHook.run (node:internal/test_runner/test:631:25)
      at TestHook.run (node:internal/test_runner/test:856:18)
      at TestHook.run (node:internal/util:522:12)
      at node:internal/test_runner/test:565:20
      at async Suite.runHook (node:internal/test_runner/test:563:7)
      at async Suite.run (node:internal/test_runner/test:945:7)
      at async startSubtest (node:internal/test_runner/harness:216:3)

ℹ tests 1
ℹ suites 1
ℹ pass 0
ℹ fail 0
ℹ cancelled 1
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 15.439667

✖ failing tests:

test at file:/Users/pulkitgupta/Desktop/node/index.mjs:13:3
✖ should be ok
  'test did not finish before its parent and was cancelled'

test at file:/Users/pulkitgupta/Desktop/node/index.mjs:3:1
✖ failing test suite (3.217584ms)
  Error: error
      at SuiteContext.<anonymous> (file:///Users/pulkitgupta/Desktop/node/index.mjs:6:11)
      at TestHook.runInAsyncScope (node:async_hooks:206:9)
      at TestHook.run (node:internal/test_runner/test:631:25)
      at TestHook.run (node:internal/test_runner/test:856:18)
      at TestHook.run (node:internal/util:522:12)
      at node:internal/test_runner/test:565:20
      at async Suite.runHook (node:internal/test_runner/test:563:7)
      at async Suite.run (node:internal/test_runner/test:945:7)
      at async startSubtest (node:internal/test_runner/harness:216:3)
pulkitgupta@Pulkits-MacBook-Air node % 

ref: #50842 (comment)

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[MoLow]

LGTM. can you please amend the commit message to adher guidlines?

[pulkit-30]

@rluvaton PTAL

[rluvaton]

@pulkit-30 I have a lot of GitHub notifications so I'm likely gonna miss something. if I do, you can ping me at https://twitter.com/rluvaton

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56352/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/51062
✔  Done loading data for nodejs/node/pull/51062
----------------------------------- PR info ------------------------------------
Title      test_runner: fix after hook inside test suite is not executed if before() throws an error (#51062)
Author     Pulkit Gupta  (@pulkit-30)
Branch     pulkit-30:fix-50842 -> nodejs:main
Labels     author ready, needs-ci, test_runner
Commits    2
 - test_runner: fixed to run after hook if before throws an error
 - fix tests
Committers 1
 - pulkit-30 
PR-URL: https://github.com/nodejs/node/pull/51062
Refs: https://github.com/nodejs/node/issues/50842
Reviewed-By: Moshe Atlow 
Reviewed-By: Raz Luvaton 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51062
Refs: https://github.com/nodejs/node/issues/50842
Reviewed-By: Moshe Atlow 
Reviewed-By: Raz Luvaton 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 05 Dec 2023 14:47:02 GMT
   ✔  Approvals: 2
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/51062#pullrequestreview-1766090728
   ✔  - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/51062#pullrequestreview-1785478063
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-12-17T17:25:50Z: https://ci.nodejs.org/job/node-test-pull-request/56352/
- Querying data for job/node-test-pull-request/56352/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 51062
From https://github.com/nodejs/node
 * branch                  refs/pull/51062/merge -> FETCH_HEAD
✔  Fetched commits as 0afe731d357d..7bef78c9d7d3
--------------------------------------------------------------------------------
[main d72d26f820] test_runner: fixed to run after hook if before throws an error
 Author: pulkit-30 
 Date: Wed Dec 6 07:04:01 2023 +0530
 4 files changed, 87 insertions(+), 8 deletions(-)
[main 15f53e6fb6] fix tests
 Author: pulkit-30 
 Date: Wed Dec 6 07:07:39 2023 +0530
 2 files changed, 3 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test_runner: fixed to run after hook if before throws an error
PR-URL: #51062

Refs: #50842

Reviewed-By: Moshe Atlow [email protected]

Reviewed-By: Raz Luvaton [email protected]
[detached HEAD abcb705896] test_runner: fixed to run after hook if before throws an error

Author: pulkit-30 [email protected]

Date: Wed Dec 6 07:04:01 2023 +0530

4 files changed, 87 insertions(+), 8 deletions(-)

Rebasing (3/4)

Rebasing (4/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fix tests
PR-URL: #51062

Refs: #50842

Reviewed-By: Moshe Atlow [email protected]

Reviewed-By: Raz Luvaton [email protected]
[detached HEAD 87d85068e6] fix tests

Author: pulkit-30 [email protected]

Date: Wed Dec 6 07:07:39 2023 +0530

2 files changed, 3 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/7240829485

[nodejs-github-bot]

Landed in 71e19e8