tools: lint for dangling commas

.eslintrc

@@ -17,6 +17,8 @@ ecmaFeatures:
 rules:
   # Possible Errors
   # list: https://github.com/eslint/eslint/tree/master/docs/rules#possible-errors
+  ## disallow trailing commas on final line of object/array declaration
+  comma-dangle: 2
   ## check debugger sentence
   no-debugger: 2
   ## check duplicate arguments

lib/cluster.js

@@ -647,7 +647,7 @@ function workerInit() {
       close: close,
       listen: listen,
       ref: ref,
-      unref: unref,
+      unref: unref
     };
     if (message.sockname) {
       handle.getsockname = getsockname;  // TCP handles only.

lib/internal/child_process.js

@@ -549,7 +549,7 @@ function setupChannel(target, channel) {
         this._handleQueue.push({
           callback: callback,
           handle: handle,
-          message: message.msg,
+          message: message.msg
         });
         return this._handleQueue.length === 1;
       }
@@ -575,7 +575,7 @@ function setupChannel(target, channel) {
       this._handleQueue.push({
         callback: callback,
         handle: null,
-        message: message,
+        message: message
       });
       return this._handleQueue.length === 1;
     }

test/addons/make-callback/test.js

@@ -30,7 +30,7 @@ const recv = {
     assert.strictEqual(this, recv);
     assert.strictEqual(x, 1337);
     return 42;
-  }),
+  })
 };
 
 assert.strictEqual(42, makeCallback(recv, 'one'));

test/addons/repl-domain-abort/test.js

@@ -20,7 +20,7 @@ var lines = [
   // This line shouldn't cause an assertion error.
   'require(\'' + buildPath + '\')' +
   // Log output to double check callback ran.
-  '.method(function() { console.log(\'cb_ran\'); });',
+  '.method(function() { console.log(\'cb_ran\'); });'
 ];
 
 var dInput = new stream.Readable();

test/common.js

@@ -90,7 +90,7 @@ exports.localIPv6Hosts = [
   'ipv6-loopback',
 
   // Typically universal
-  'localhost',
+  'localhost'
 ];
 
 Object.defineProperty(exports, 'inFreeBSDJail', {

test/debugger/test-debugger-repl-restart.js

@@ -14,7 +14,7 @@ initialLines.splice(2, 0, /Restoring/, /Warning/);
 
 // Restart the debugged script
 repl.addTest('restart', [
-  /terminated/,
+  /terminated/
 ].concat(initialLines));
 
 repl.addTest('list(5)', linesWithBreakpoint);

test/debugger/test-debugger-repl-term.js

@@ -19,7 +19,7 @@ addTest('n', [
 addTest('', [
   /debug>/,
   /break in .*:5/,
-  /3/, /4/, /5/, /6/, /7/,
+  /3/, /4/, /5/, /6/, /7/
 ]);
 
 // continue
@@ -33,12 +33,12 @@ addTest('c', [
 addTest('', [
   /debug>/,
   /break in .*:5/,
-  /3/, /4/, /5/, /6/, /7/,
+  /3/, /4/, /5/, /6/, /7/
 ]);
 
 // should repeat continue
 addTest('', [
   /debug>/,
   /break in .*:23/,
-  /21/, /22/, /23/, /24/, /25/,
+  /21/, /22/, /23/, /24/, /25/
 ]);

test/parallel/test-cluster-setup-master-cumulative.js

@@ -13,7 +13,7 @@ assert.deepEqual(cluster.settings, {
   args: process.argv.slice(2),
   exec: process.argv[1],
   execArgv: process.execArgv,
-  silent: false,
+  silent: false
 });
 console.log('ok sets defaults');
 
@@ -36,6 +36,6 @@ assert.deepEqual(cluster.settings, {
   args: ['foo', 'bar'],
   exec: 'overridden',
   execArgv: ['baz', 'bang'],
-  silent: false,
+  silent: false
 });
 console.log('ok preserves current settings');

test/parallel/test-cluster-setup-master-multiple.js

@@ -24,7 +24,7 @@ cluster.on('setup', function() {
 var execs = [
   'node-next',
   'node-next-2',
-  'node-next-3',
+  'node-next-3'
 ];
 
 process.on('exit', function assertTests() {

test/parallel/test-crypto-dh.js

@@ -254,7 +254,7 @@ ecdh5.setPrivateKey(cafebabeKey, 'hex');
 [ // Some invalid private keys for the secp256k1 curve.
   '0000000000000000000000000000000000000000000000000000000000000000',
   'FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFEBAAEDCE6AF48A03BBFD25E8CD0364141',
-  'FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF',
+  'FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF'
 ].forEach(function(element, index, object) {
   assert.throws(function() {
     ecdh5.setPrivateKey(element, 'hex');

test/parallel/test-crypto-hmac.js

@@ -56,7 +56,7 @@ var wikipedia = [
           'b613679a0814d9ec772f95d778c35fc5ff1697c493715653c6c71214' +
           '4292c5ad'
     }
-  },
+  }
 ];
 
 for (let i = 0, l = wikipedia.length; i < l; i++) {

test/parallel/test-debug-signal-cluster.js

@@ -67,7 +67,7 @@ var expectedLines = [
   'Starting debugger agent.',
   'Debugger listening on port ' + (port + 1),
   'Starting debugger agent.',
-  'Debugger listening on port ' + (port + 2),
+  'Debugger listening on port ' + (port + 2)
 ];
 
 function assertOutputLines() {

test/parallel/test-dns.js

@@ -11,7 +11,7 @@ function noop() {}
 
 var goog = [
   '8.8.8.8',
-  '8.8.4.4',
+  '8.8.4.4'
 ];
 assert.doesNotThrow(function() { dns.setServers(goog); });
 assert.deepEqual(dns.getServers(), goog);
@@ -20,7 +20,7 @@ assert.deepEqual(dns.getServers(), goog);
 
 var goog6 = [
   '2001:4860:4860::8888',
-  '2001:4860:4860::8844',
+  '2001:4860:4860::8844'
 ];
 assert.doesNotThrow(function() { dns.setServers(goog6); });
 assert.deepEqual(dns.getServers(), goog6);
@@ -31,11 +31,11 @@ assert.deepEqual(dns.getServers(), goog6);
 
 var ports = [
   '4.4.4.4:53',
-  '[2001:4860:4860::8888]:53',
+  '[2001:4860:4860::8888]:53'
 ];
 var portsExpected = [
   '4.4.4.4',
-  '2001:4860:4860::8888',
+  '2001:4860:4860::8888'
 ];
 dns.setServers(ports);
 assert.deepEqual(dns.getServers(), portsExpected);

test/parallel/test-domain-no-error-handler-abort-on-uncaught.js

@@ -134,7 +134,7 @@ const tests = [
         });
       });
     });
-  },
+  }
 ];
 
 if (process.argv[2] === 'child') {

test/parallel/test-http-agent-error-on-idle.js

@@ -5,7 +5,7 @@ var http = require('http');
 var Agent = http.Agent;
 
 var agent = new Agent({
-  keepAlive: true,
+  keepAlive: true
 });
 
 var requestParams = {

test/parallel/test-http-client-timeout-agent.js

@@ -9,7 +9,7 @@ var requests_done = 0;
 var options = {
   method: 'GET',
   port: common.PORT,
-  host: '127.0.0.1',
+  host: '127.0.0.1'
 };
 
 //http.globalAgent.maxSockets = 15;

test/parallel/test-http-content-length.js

@@ -5,17 +5,17 @@ var http = require('http');
 
 var expectedHeadersMultipleWrites = {
   'connection': 'close',
-  'transfer-encoding': 'chunked',
+  'transfer-encoding': 'chunked'
 };
 
 var expectedHeadersEndWithData = {
   'connection': 'close',
-  'content-length': 'hello world'.length,
+  'content-length': 'hello world'.length
 };
 
 var expectedHeadersEndNoData = {
   'connection': 'close',
-  'content-length': '0',
+  'content-length': '0'
 };
 
 var receivedRequests = 0;

test/parallel/test-http-flush-headers.js

@@ -13,7 +13,7 @@ server.listen(common.PORT, '127.0.0.1', function() {
   const req = http.request({
     method: 'GET',
     host: '127.0.0.1',
-    port: common.PORT,
+    port: common.PORT
   });
   req.setHeader('foo', 'bar');
   req.flushHeaders();

test/parallel/test-http-flush-response-headers.js

@@ -14,7 +14,7 @@ server.listen(common.PORT, common.localhostIPv4, function() {
   var req = http.request({
     method: 'GET',
     host: common.localhostIPv4,
-    port: common.PORT,
+    port: common.PORT
   }, onResponse);
 
   req.end();

test/parallel/test-http-flush.js

@@ -9,7 +9,7 @@ http.createServer(function(req, res) {
   var req = http.request({
     method: 'POST',
     host: '127.0.0.1',
-    port: common.PORT,
+    port: common.PORT
   });
   req.flush();  // Flush the request headers.
   req.flush();  // Should be idempotent.

test/parallel/test-http-server-multiheaders.js

@@ -52,7 +52,7 @@ srv.listen(common.PORT, function() {
       ['sec-websocket-extensions', 'baz'],
       ['constructor', 'foo'],
       ['constructor', 'bar'],
-      ['constructor', 'baz'],
+      ['constructor', 'baz']
     ]
   });
 });

test/parallel/test-http-server-multiheaders2.js

@@ -28,7 +28,7 @@ var multipleAllowed = [
 
   // make sure that unspecified headers is treated as multiple
   'Some-Random-Header',
-  'X-Some-Random-Header',
+  'X-Some-Random-Header'
 ];
 
 var multipleForbidden = [
@@ -42,7 +42,7 @@ var multipleForbidden = [
   'If-Unmodified-Since',
   'From',
   'Location',
-  'Max-Forwards',
+  'Max-Forwards'
 
   // special case, tested differently
   //'Content-Length',
@@ -85,6 +85,6 @@ srv.listen(common.PORT, function() {
     host: 'localhost',
     port: common.PORT,
     path: '/',
-    headers: headers,
+    headers: headers
   });
 });

test/parallel/test-http-server-stale-close.js

@@ -9,7 +9,7 @@ if (process.env.NODE_TEST_FORK) {
     headers: {'Content-Length': '42'},
     method: 'POST',
     host: '127.0.0.1',
-    port: common.PORT,
+    port: common.PORT
   }, process.exit);
   req.write('BAM');
   req.end();

test/parallel/test-listen-fd-cluster.js

@@ -41,7 +41,7 @@ test(function(parent) {
   http.get({
     server: 'localhost',
     port: PORT,
-    path: '/',
+    path: '/'
   }).on('response', function(res) {
     var s = '';
     res.on('data', function(c) {

test/parallel/test-listen-fd-detached-inherit.js

@@ -39,7 +39,7 @@ function test() {
     http.get({
       server: 'localhost',
       port: PORT,
-      path: '/',
+      path: '/'
     }).on('response', function(res) {
       var s = '';
       res.on('data', function(c) {

test/parallel/test-listen-fd-detached.js

@@ -39,7 +39,7 @@ function test() {
     http.get({
       server: 'localhost',
       port: PORT,
-      path: '/',
+      path: '/'
     }).on('response', function(res) {
       var s = '';
       res.on('data', function(c) {

test/parallel/test-listen-fd-server.js

@@ -30,7 +30,7 @@ test(function(child) {
   http.get({
     server: 'localhost',
     port: PORT,
-    path: '/',
+    path: '/'
   }).on('response', function(res) {
     var s = '';
     res.on('data', function(c) {

test/parallel/test-net-localerror.js

@@ -6,13 +6,13 @@ var net = require('net');
 connect({
   host: 'localhost',
   port: common.PORT,
-  localPort: 'foobar',
+  localPort: 'foobar'
 }, 'localPort should be a number: foobar');
 
 connect({
   host: 'localhost',
   port: common.PORT,
-  localAddress: 'foobar',
+  localAddress: 'foobar'
 }, 'localAddress should be a valid IP: foobar');
 
 function connect(opts, msg) {

test/parallel/test-path-parse-format.js

@@ -72,7 +72,7 @@ const errors = [
   {method: 'format', input: [true],
    message: /Parameter "pathObject" must be an object, not boolean/},
   {method: 'format', input: [1],
-   message: /Parameter "pathObject" must be an object, not number/},
+   message: /Parameter "pathObject" must be an object, not number/}
 ];
 
 checkParseFormat(path.win32, winPaths);