assert: fix deepEqual always return true on URL

[meixg]

Fixes: #50836

[anonrig]

LGTM

[aduh95]

Related test failure:

=== release test-whatwg-url-custom-inspect ===
Path: parallel/test-whatwg-url-custom-inspect
Error: --- stderr ---
node:assert:126
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ '{ a: ***host.name:8080/path/name/?que=ry#hash }'
- '{ a: URL {} }'
    at Object.<anonymous> (/home/runner/work/node/node/test/parallel/test-whatwg-url-custom-inspect.js:65:8)
    at Module._compile (node:internal/modules/cjs/loader:1375:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1434:10)
    at Module.load (node:internal/modules/cjs/loader:1206:32)
    at Module._load (node:internal/modules/cjs/loader:1022:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:142:12)
    at node:internal/main/run_main_module:28:49 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: '{ a: ***host.name:8080/path/name/?que=ry#hash }',
  expected: '{ a: URL {} }',
  operator: 'strictEqual'
}

[meixg]

Related test failure:

=== release test-whatwg-url-custom-inspect ===
Path: parallel/test-whatwg-url-custom-inspect
Error: --- stderr ---
node:assert:126
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ '{ a: ***host.name:8080/path/name/?que=ry#hash }'
- '{ a: URL {} }'
    at Object.<anonymous> (/home/runner/work/node/node/test/parallel/test-whatwg-url-custom-inspect.js:65:8)
    at Module._compile (node:internal/modules/cjs/loader:1375:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1434:10)
    at Module.load (node:internal/modules/cjs/loader:1206:32)
    at Module._load (node:internal/modules/cjs/loader:1022:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:142:12)
    at node:internal/main/run_main_module:28:49 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: '{ a: ***host.name:8080/path/name/?que=ry#hash }',
  expected: '{ a: URL {} }',
  operator: 'strictEqual'
}

fixed

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55867/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55869/

[BridgeAR]

The detection is not checking for an actual instance of URL and it's just a heuristic which can trigger for lots of other objects as well. Assert has to be very strict about knowing what to check for. We would need a proper check for being an URL object and that's something we can not easily do.

Update: The check is actually just additive, so it should be ok in assert. I would still like to see if we can just rely upon changing URL instead of assert and util.

[theoludwig]

What is the status of this PR? Is there any way, can anyone help to move this forward? 😄

[MCprotein]

@meixg hi, What is the current status of this PR?

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[RedYetiDev]

Hi! People appear to have been requesting updates since March. For that reason, I've marked this PR as stalled. When action is taken, I'll be happy to un-mark it :-).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (98788da) to head (722bdd8).
Report is 366 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #50853      +/-   ##
==========================================
+ Coverage   87.89%   88.41%   +0.52%     
==========================================
  Files         652      652              
  Lines      186589   186792     +203     
  Branches    35750    36052     +302     
==========================================
+ Hits       163999   165149    +1150     
+ Misses      15816    14900     -916     
+ Partials     6774     6743      -31     

Files with missing lines	Coverage Δ
lib/internal/util/comparisons.js	100.00% <100.00%> (ø)
lib/internal/util/inspect.js	99.95% <100.00%> (-0.05%)	⬇️

... and 130 files with indirect coverage changes

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63071/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63075/

[BridgeAR]

@meixg thank you for following up and sticking to it!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63079/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63081/

[nodejs-github-bot]

Landed in ac49b20

[ruyadorno]

This commit does not land cleanly on v22.x-staging and will need manual backport in case we want it in v22.x.