tools: remove npm install from acorn update #50473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
lpinca
approved these changes
Oct 30, 2023
| @@ -17,7 +17,7 @@ DEPS_DIR="$BASE_DIR/deps" | |||
| . "$BASE_DIR/tools/dep_updaters/utils.sh" | |||
|
|
|||
| NEW_VERSION=$("$NODE" "$NPM" view acorn-walk dist-tags.latest) | |||
| CURRENT_VERSION=$("$NODE" -p "require('./deps/acorn/acorn-walk/package.json').version") | |||
| CURRENT_VERSION=$("$NODE" "$NPM" --prefix './deps/acorn/acorn-walk/' pkg get version) | |||
There was a problem hiding this comment.
Any reason for this? Using npm seems overkill.
There was a problem hiding this comment.
Not a particular reason, it feels more clean since its npm pkg get does exactly that
There was a problem hiding this comment.
I prefer the original one and it's faster.
|
|
||
| NEW_VERSION=$("$NODE" "$NPM" view acorn dist-tags.latest) | ||
| CURRENT_VERSION=$("$NODE" -p "require('./deps/acorn/acorn/package.json').version") | ||
| CURRENT_VERSION=$("$NODE" "$NPM" --prefix './deps/acorn/acorn/' pkg get version) |
ShogunPanda
approved these changes
Nov 1, 2023
marco-ippolito
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2a1bd66 |
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Nov 9, 2023
PR-URL: nodejs#50473 Refs: nodejs/security-wg#1037 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50473 Refs: nodejs/security-wg#1037 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 14, 2023
PR-URL: #50473 Refs: nodejs/security-wg#1037 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50473 Refs: nodejs/security-wg#1037 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/security-wg#1037