[v18.x] deps: update nghttp2 to 1.57.0 #50151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c8da8c8.
PR-URL: nodejs#47997 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: nodejs#48746 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: nodejs#48790 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: nodejs#49582 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#50121 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
build
richardlau
added
request-ci
github-actions
bot
removed
the
request-ci
gengjiawen
approved these changes
Oct 12, 2023
|
Landed in b2b3118...a792bbc. |
richardlau
added a commit
that referenced
this pull request
Oct 12, 2023
This reverts commit c8da8c8. PR-URL: #50151 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Oct 12, 2023
PR-URL: #47997 Backport-PR-URL: #50151 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Oct 12, 2023
PR-URL: #48746 Backport-PR-URL: #50151 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Oct 12, 2023
PR-URL: #48790 Backport-PR-URL: #50151 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Oct 12, 2023
PR-URL: #49582 Backport-PR-URL: #50151 Reviewed-By: Luigi Pinca <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Oct 12, 2023
PR-URL: #50121 Backport-PR-URL: #50151 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
richardlau
added
the
v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport to Node.js 18 of:
Node.js 18.18.0 went out with the nghttp2 1.55.0 update (#48746) but without first applying the nghttp2 1.53.0 update (#47997). #47997 was blocked because it depended on part of #46965.
I've reverted the ngthttp2 1.55.0 commit on v18.x-staging, and then re-cherry-picked the nghttp2 update commits from main, fixing up conflicts along the way. For #47997 that involved manually fixing up
nghttp2.gyp.Subsequent updates had conflicts in
doc/contributing/maintaining/maintaining-dependencies.mdbecause we haven't backported #48081 -- for these I've undone the changes to themaintaining-dependencies.mdfile via:git checkout --ours HEAD -- doc/contributing/maintaining/maintaining-dependencies.md