Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix argument computation in embedtest #49506

Closed
wants to merge 4 commits into from

Commits on Sep 8, 2023

  1. bootstrap: do not expand argv1 for snapshots

    To avoid capturing build machine states into the snapshot
    joyeecheung committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    a779b0d View commit details
    Browse the repository at this point in the history
  2. test: fix argument computation in embedtest

    There were a few bugs in the original test that went unnoticed
    because with the bug the test did not actually get run anymore.
    This patch fixes the argument computation by accounting filtering
    of the arguments, and uses spawnSyncAndExit{WithoutError} in
    the test to enable better logging when the test fails.
    joyeecheung committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    2b541e3 View commit details
    Browse the repository at this point in the history
  3. build: run embedtest using node executable

    We should use the node executable to run this test, instead of
    counting on embedtest, the binary being tested, as the test runner.
    Otherwise bugs can go unnoticed if the embedtest binary itself
    does not work correctly.
    joyeecheung committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8b9b658 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Configuration menu
    Copy the full SHA
    fbf82ab View commit details
    Browse the repository at this point in the history