Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scheduling policy to cluster.settings #49292

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+68 −3
Open

Add scheduling policy to cluster.settings #49292

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
13ad0b9
cluster: fold schedulingPolicy into cluster.settings
alexfernandez Aug 22, 2023
7b40262
cluster: add internal cluster.getSettings() for test
alexfernandez Aug 22, 2023
cfde107
cluster: add test for cluster.setPrimary({schedulingPolicy})
alexfernandez Aug 22, 2023
55af83d
cluster: document cluster.setPrimary({schedulingPolicy})
alexfernandez Aug 22, 2023
4421342
cluster: remove comment from bnoordhuis
alexfernandez Aug 28, 2023
0648d42
As suggested by mcollina
alexfernandez Oct 22, 2023
0568aa6
As suggested by jerome-benoit: remove comment
alexfernandez Oct 22, 2023
c5a082b
Fix tests
alexfernandez Nov 1, 2023
e4a3101
Add pull request number
alexfernandez Nov 1, 2023
06e0916
cluster: fix test, revert known_issue so it fails now
alexfernandez Nov 1, 2023
9f797a2
cluster: add scheduling policy to `cluster.settings`
alexfernandez Aug 22, 2023
0929cc4
Merge branch 'fix/schedulingPolicy-import' of github.com:alexfernande…
alexfernandez May 12, 2024
9d60e38
Document getSettings()
alexfernandez May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cluster: remove comment from bnoordhuis
  • Loading branch information
@alexfernandez
alexfernandez committed Nov 1, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 44213422bb9e2bd4c41f51b726950ad165bcc47d
1 change: 0 additions & 1 deletion lib/internal/cluster/primary.js
View file
Original file line number Diff line number Diff line change
@@ -44,7 +44,6 @@ cluster.SCHED_RR = SCHED_RR; // Primary distributes connections.
let ids = 0;
let initialized = false;

// XXX(bnoordhuis) Fold cluster.schedulingPolicy into cluster.settings?
// XXX(alexfernandez) Folded cluster.schedulingPolicy into cluster.settings.
let schedulingPolicy = process.env.NODE_CLUSTER_SCHED_POLICY;
if (schedulingPolicy === 'rr')