Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: remove globalPreload hook (superseded by initialize) #49144

Merged
merged 21 commits into from
Sep 10, 2023
Merged

esm: remove globalPreload hook (superseded by initialize) #49144

merged 21 commits into from
Sep 10, 2023

Commits on Sep 10, 2023

  1. esm: remove globalPreload hook (superseded by initialize)

    @JakobJingleheimer @GeoffreyBooth
    JakobJingleheimer authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    590129d View commit details
    Browse the repository at this point in the history

  2. remove 'preload' execution

    @JakobJingleheimer @GeoffreyBooth
    JakobJingleheimer authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    d31c02f View commit details
    Browse the repository at this point in the history

  3. update ESM doc (remove globalPreload section

    @JakobJingleheimer @GeoffreyBooth
    JakobJingleheimer authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    8066690 View commit details
    Browse the repository at this point in the history

  4. suppress warnings in test cases

    @JakobJingleheimer @GeoffreyBooth
    JakobJingleheimer authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    d57f651 View commit details
    Browse the repository at this point in the history

  5. remove unused deps

    @JakobJingleheimer @GeoffreyBooth
    JakobJingleheimer authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    68b46f4 View commit details
    Browse the repository at this point in the history

  6. !includes → doesNotMatch

    @JakobJingleheimer @GeoffreyBooth
    JakobJingleheimer authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    4b48ef5 View commit details
    Browse the repository at this point in the history

  7. simplify initializeHooks return { hooks } → hooks

    @JakobJingleheimer @GeoffreyBooth
    JakobJingleheimer authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    f4a89e4 View commit details
    Browse the repository at this point in the history

  8. WIP: exposed error? (need to remove catches, debugs, etc)

    @JakobJingleheimer @GeoffreyBooth
    JakobJingleheimer authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    5226236 View commit details
    Browse the repository at this point in the history

  9. WIP

    @JakobJingleheimer @GeoffreyBooth
    JakobJingleheimer authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    bd04cb9 View commit details
    Browse the repository at this point in the history

  10. remove writeFileSync debugging

    @JakobJingleheimer @GeoffreyBooth
    JakobJingleheimer authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    c5e0934 View commit details
    Browse the repository at this point in the history

  11. Delete test that only tests side effects of globalPreload

    @GeoffreyBooth
    GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    b906a4e View commit details
    Browse the repository at this point in the history

  12. Change warning type

    @GeoffreyBooth
    GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    253a03d View commit details
    Browse the repository at this point in the history

  13. Lint, cleanup

    @GeoffreyBooth
    GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    ebd986f View commit details
    Browse the repository at this point in the history

  14. Restore refactored hook-resolve-type test

    @GeoffreyBooth
    GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    ae94731 View commit details
    Browse the repository at this point in the history

  15. Lint

    @GeoffreyBooth
    GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    ad6bb1f View commit details
    Browse the repository at this point in the history

  16. Apply suggestion from code review

    @aduh95 @GeoffreyBooth
    aduh95 authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    c09582f View commit details
    Browse the repository at this point in the history

  17. lint

    @aduh95 @GeoffreyBooth
    aduh95 authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    b1db565 View commit details
    Browse the repository at this point in the history

  18. Update lib/internal/modules/esm/hooks.js

    @GeoffreyBooth
    GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    c5eaaeb View commit details
    Browse the repository at this point in the history

  19. Update lib/internal/modules/esm/hooks.js

    @aduh95 @GeoffreyBooth
    aduh95 authored and GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    8e39882 View commit details
    Browse the repository at this point in the history

  20. Fixup

    @GeoffreyBooth
    GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    05a88fd View commit details
    Browse the repository at this point in the history

  21. Remove isolated file

    @GeoffreyBooth
    GeoffreyBooth committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    42e6321 View commit details
    Browse the repository at this point in the history