Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added website team to sharing project news #49002

Merged
merged 1 commit into from
Feb 27, 2024
Merged

docs: added website team to sharing project news #49002

merged 1 commit into from
Feb 27, 2024

Conversation

UlisesGascon
Copy link
Member

cc: @nodejs/next-10

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 3, 2023
@UlisesGascon UlisesGascon mentioned this pull request Aug 3, 2023
Merged
@UlisesGascon UlisesGascon marked this pull request as ready for review August 3, 2023 06:34
@aduh95
Copy link
Contributor

aduh95 commented Aug 3, 2023

Can you fix the commit message please? It should start with an imperative verb (i.e. s/added/add/) per

node/doc/contributing/pull-requests.md

Lines 168 to 175 in 260092e

* be prefixed with the name of the changed [subsystem](#appendix-subsystems)
and start with an imperative verb. Check the output of `git log --oneline
files/you/changed` to find out what subsystems your changes touch.
Examples:
* `net: add localAddress and localPort to Socket`
* `src: fix typos in async_wrap.h`

mhdawson
mhdawson approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@UlisesGascon can you squash to 1 commit? I think that would fix the remaing CI complaint.

@UlisesGascon UlisesGascon force-pushed the UlisesGascon-patch-1 branch 2 times, most recently from 10e4a31 to 1891929 Compare February 26, 2024 08:53
@UlisesGascon
Copy link
Member Author

I forgot this PR for a while, I just updated the branch with the last changes from main and clean up the historial, so now I think that is fine 👍

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2024
@nodejs-github-bot nodejs-github-bot merged commit f28ccd3 into nodejs:main Feb 27, 2024
15 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f28ccd3

marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
@UlisesGascon @marco-ippolito
doc: add website team to sharing project news
7491dbb 
PR-URL: #49002
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
@UlisesGascon @marco-ippolito
doc: add website team to sharing project news
2cdfe35 
PR-URL: #49002
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@UlisesGascon @richardlau
doc: add website team to sharing project news
aed3d8a 
PR-URL: #49002
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@UlisesGascon @richardlau
doc: add website team to sharing project news
a74c373 
PR-URL: #49002
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@UlisesGascon @rdw-msft
doc: add website team to sharing project news
83cd51d 
PR-URL: nodejs#49002
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymen94 aymen94 aymen94 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

@lpinca lpinca lpinca approved these changes

@wesleytodd wesleytodd wesleytodd approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@UlisesGascon @nodejs-github-bot @aduh95 @mhdawson @jasnell @wesleytodd @lpinca @legendecas @aymen94