Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V20.5.0 proposal #48761

Merged
merged 55 commits into from
Jul 20, 2023
Merged

V20.5.0 proposal #48761

merged 55 commits into from
Jul 20, 2023

Conversation

juanarbol
Copy link
Member

@juanarbol juanarbol commented Jul 13, 2023 •
edited
Loading

2023-07-18, Version 20.5.0 (Current), @juanarbol

Notable Changes

  • [45be29d89f] - doc: add atlowChemi to collaborators (atlowChemi) #48757
  • [a316808136] - (SEMVER-MINOR) events: allow safely adding listener to abortSignal (Chemi Atlow) #48596
  • [986b46a567] - fs: add a fast-path for readFileSync utf-8 (Yagiz Nizipli) #48658
  • [0ef73ff6f0] - (SEMVER-MINOR) test_runner: add shards support (Raz Luvaton) #48639

Commits

tniessen and others added 30 commits July 13, 2023 16:44
@tniessen @juanarbol
src: deduplicate X509 getter implementations
df363d0 
Reorder arguments of internal helper functions such that their order is
consistent across X509 property getters. Add ReturnPropertyThroughBIO()
and ReturnProperty(). Use these new helpers to deduplicate code across
various X509 property getters.

PR-URL: #48563
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Alba Mendez <[email protected]>
@dependabot @juanarbol
meta: bump github/codeql-action from 2.3.6 to 2.20.1
25c5a0a 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.3.6 to 2.20.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@83f0fe6...f6e388e)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #48627
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@dependabot @juanarbol
meta: bump ossf/scorecard-action from 2.1.3 to 2.2.0
332e480 
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.3 to 2.2.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@80e868c...08b4669)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #48628
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@H4ad @juanarbol
src,lib: reducing C++ calls of esm legacy main resolve
9cf2e1f 
Instead of many C++ calls, now we make only one C++ call
to return a enum number that represents the selected state.

PR-URL: #48325
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@dependabot @juanarbol
meta: bump step-security/harden-runner from 2.4.0 to 2.4.1
b5cb69c 
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@128a634...55d479f)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #48626
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@nodejs-github-bot @juanarbol
tools: update lint-md-dependencies to [email protected]
42dc6eb 
PR-URL: #48631
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@nodejs-github-bot @juanarbol
tools: update eslint to 8.44.0
a1f4ff7 
PR-URL: #48632
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
@RafaelGSS @Haxatron @juanarbol
permission: v8.writeHeapSnapshot and process.report
f4333b1 
Co-Authored-By: haxatron <[email protected]>
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: #48564
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@dependabot @juanarbol
meta: bump actions/checkout from 3.5.2 to 3.5.3
dff6c25 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.2 to 3.5.3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@8e5e7e5...c85c95e)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #48625
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@legendecas @juanarbol
bootstrap: hide experimental web globals with flag kNoBrowserGlobals
e2d0195 
Do not install experimental web globals when the environment is
initialized with embedder flag
`node::EnvironmentFlags::kNoBrowserGlobals`.

PR-URL: #48545
Reviewed-By: Colin Ihrig <[email protected]>
@MoLow @juanarbol
child_process: support Symbol.dispose
4e08160 
PR-URL: #48551
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow @juanarbol
timers: support Symbol.dispose
e2442bb 
PR-URL: #48633
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
@lpinca @juanarbol
Revert "test: remove test-crypto-keygen flaky designation"
dfa0aee 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@atlowChemi @juanarbol
events: allow safely adding listener to abortSignal
a316808 
PR-URL: #48596
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
@devm33 @juanarbol
http2: send RST code 8 on AbortController signal
4a0b66e 
Fixes: #47321
Refs: https://www.rfc-editor.org/rfc/rfc7540#section-7
PR-URL: #48573
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@RafaelGSS @juanarbol
doc: mention git node release prepare
dd7ea3e 
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: #48644
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@RafaelGSS @juanarbol
doc: drop <b> of v20 changelog
7daefae 
PR-URL: #48649
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@yoavain @juanarbol
doc: fix copy node executable in Windows
999ae0c 
Windows where command lists all places it finds a pattern in Path.
The first one is the one that executes when called.
So the old code was overriding the first executable by any other match.

PR-URL: #48624
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@npm-cli-bot @juanarbol
deps: upgrade npm to 9.8.0
150e155 
PR-URL: #48665
Reviewed-By: Luke Karrys <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@rafasofizada @juanarbol
doc: clarify transform._transform() callback argument logic
caccb05 
Clarify that `transform._transform()` callback second argument is
used only if the first argument is `null`, i.e. no error occured
processing the chunk.

PR-URL: #48680
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@yuzheng14 @juanarbol
events: fix bug listenerCount don't compare wrapped listener
67b13d1 
When add listener by once, it will be wrapped into another function.
And when pass listener and there is just one event listener added by
once, it will return 0 even if passed listener equal wrapped event
listener.

Refs: #46523
PR-URL: #48592
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@kvakil @juanarbol
src: remove kEagerCompile for CompileFunction
d99ea48 
It wasn't doing anything, and actually enabling it would cause some
tests to fail.

Refs: #48576
PR-URL: #48671
Refs: v8/v8@cb00db4
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@kvakil @juanarbol
deps: V8: cherry-pick cb00db4dba6c
b7a076a 
Original commit message:

    [compiler] fix CompileFunction ignoring kEagerCompile

    v8::ScriptCompiler::CompileFunction was ignoring kEagerCompile. Unlike
    the other functions in v8::ScriptCompiler, it was not actually
    propagating kEagerCompile to the parser. The newly updated test fails
    without this change.

    I did some archeology and found that this was commented out since the
    original CL in https://crrev.com/c/980944.

    As far as I know Node.js is the main consumer of this particular API.
    This CL speeds up Node.js's overall startup time by ~13%.

    Change-Id: Ifc3cd6653555194d46ca48db14f7ba7a4afe0053
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4571822
    Commit-Queue: Marja Hölttä <[email protected]>
    Reviewed-by: Marja Hölttä <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#87944}

Refs: v8/v8@cb00db4
PR-URL: #48671
Refs: #48576
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@nodejs-github-bot @juanarbol
tools: update lint-md-dependencies to [email protected]
b25e78a 
PR-URL: #48705
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@nodejs-github-bot @juanarbol
tools: update doc to [email protected] [email protected]
38ce95d 
PR-URL: #48714
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@aduh95 @juanarbol
esm: fix emit deprecation on legacy main resolve
cc7809d 
PR-URL: #48664
Refs: #48325
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@atlowChemi @juanarbol
http2: use addAbortListener
e4333ac 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@atlowChemi @juanarbol
readline: use addAbortListener
f691dca 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@atlowChemi @juanarbol
stream: use addAbortListener
5a382d0 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@atlowChemi @juanarbol
dgram: use addAbortListener
002ce31 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52856/

@juanarbol
Copy link
Member Author

juanarbol commented Jul 19, 2023 •
edited
Loading

CITGM results:

FAILURE: 28 failures in 3190 not present in 3186


┌───────────────────┬───────────────────────┬─────────────────────────┬───────────────────────┬───────────────────────────┬──────────────────────┬────────────────┬───────────────────┬──────────────┬───────────────────────────┬────────────────┐
│      (index)      │           0           │            1            │           2           │             3             │          4           │       5        │         6         │      7       │             8             │       9        │
├───────────────────┼───────────────────────┼─────────────────────────┼───────────────────────┼───────────────────────────┼──────────────────────┼────────────────┼───────────────────┼──────────────┼───────────────────────────┼────────────────┤
│   rhel8-ppc64le   │   'fastify-v4.20.0'   │ 'torrent-stream-v1.2.1' │                       │                           │                      │                │                   │              │                           │                │
│    rhel8-s390x    │   'fastify-v4.20.0'   │                         │                       │                           │                      │                │                   │              │                           │                │
│    win-vs2019     │ 'body-parser-v1.20.2' │     'pino-v8.14.1'      │ 'tough-cookie-v4.1.3' │                           │                      │                │                   │              │                           │                │
│   debian10-x64    │   'fastify-v4.20.0'   │     'pino-v8.14.1'      │                       │                           │                      │                │                   │              │                           │                │
│    aix72-ppc64    │    'async-v3.2.4'     │    'fastify-v4.20.0'    │     'pump-v3.0.0'     │   'tough-cookie-v4.1.3'   │     'ws-v8.13.0'     │                │                   │              │                           │                │
│     rhel8-x64     │   'fastify-v4.20.0'   │                         │                       │                           │                      │                │                   │              │                           │                │
│ fedora-latest-x64 │   'fastify-v4.20.0'   │    'winston-v3.10.0'    │     'ws-v8.13.0'      │ 'yeoman-generator-v5.9.0' │                      │                │                   │              │                           │                │
│   ubuntu1804-64   │    'async-v3.2.4'     │    'fastify-v4.20.0'    │    'semver-v7.5.4'    │     'through2-v4.0.2'     │ 'underscore-v1.13.6' │ 'vinyl-v3.0.0' │ 'winston-v3.10.0' │ 'ws-v8.13.0' │ 'yeoman-generator-v5.9.0' │ 'jest-v29.6.1' │
└───────────────────┴───────────────────────┴─────────────────────────┴───────────────────────┴───────────────────────────┴──────────────────────┴────────────────┴───────────────────┴──────────────┴───────────────────────────┴────────────────┘

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 19, 2023 •
edited by juanarbol
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/52857/
Release: https://ci-release.nodejs.org/job/iojs+release/9512/
Release-s390x: https://ci-release.nodejs.org/job/iojs+release/9513/

@ljharb
Copy link
Member

ljharb commented Jul 19, 2023

ping @lukekarrys for the semver failure

@lukekarrys
Copy link
Member

Of the 4 semver failures I saw on v20.5.0 and v20.4.1:

3 were citgm having install issues due to running out of space

Output 
npm ERR! code ENOSPC
npm ERR! syscall write
npm ERR! errno -28
npm ERR! nospc ENOSPC: no space left on device, write
npm ERR! nospc There appears to be insufficient space on your system to finish.
npm ERR! nospc Clear up some disk space and try again.
npm ERR! A complete log of this run can be found in: /home/iojs/tmp/citgm_tmp/5e8b54be-28b0-4d23-b3f7-3bb758973000/home/.npm/_logs/2023-07-18T19_55_53_715Z-debug-0.log

The other was a timeout due to the bin/semver.js test (which uses child_process.spawn) running very slowly

Output 
 # Subtest: test/bin/semver.js
     # Subtest: inc tests
     ok 1 - inc tests # time=28627.251ms
     
     # Subtest: help output
     ok 2 - help output # time=589.471ms
     
     # Subtest: sorting and filtering
         not ok 1 - 1.2.3 3.2.1 2.3.4
           ---
           at: {}
           found:
             !error
             name: Error
             message: error thrown while awaiting Promise
           ...
         
         
         not ok 2 - timeout!
           ---
           expired: test/bin/semver.js
           ...
         1..2
         # failed 2 of 2 tests
     not ok 3 - timeout!
     
     1..3
     # failed 1 of 3 tests
 not ok 4 - test/bin/semver.js # time=31017.384ms

I'll look into bumping up the semver timeout for that one test. The test timeout was recently added to catch redos issues.

@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Open
22 tasks
@bricss
Copy link

bricss commented Jul 20, 2023

Is there any chance to bring #48838 to the party? 🎈

@juanarbol juanarbol merged commit f13c7f5 into v20.x Jul 20, 2023
juanarbol added a commit that referenced this pull request Jul 20, 2023
@juanarbol
Working on v20.5.1
b71cbce 
PR-URL: #48761
@juanarbol juanarbol deleted the v20.5.0-proposal branch July 20, 2023 17:45
@juanarbol
Copy link
Member Author

Is there any chance to bring #48838 to the party? 🎈

Oh sorry, I ran out of time with this release and CI is not happy yet with that PR 💔

juanarbol added a commit that referenced this pull request Jul 20, 2023
@juanarbol
2023-07-18, Version 20.5.0 (Current)
d5761a4 
Notable changes:

doc:
  * add atlowChemi to collaborators (atlowChemi) #48757
events:
  * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
fs:
  * add a fast-path for readFileSync utf-8 (Yagiz Nizipli) #48658
test_runner:
  * (SEMVER-MINOR) add shards support (Raz Luvaton) #48639

PR-URL: #48761
juanarbol added a commit to juanarbol/nodejs.org that referenced this pull request Jul 20, 2023
@juanarbol
Blog: v20.5.0 release post
a187f92 
Refs: nodejs/node#48761
@juanarbol juanarbol mentioned this pull request Jul 20, 2023
Merged
5 tasks
juanarbol added a commit to nodejs/nodejs.org that referenced this pull request Jul 20, 2023
@juanarbol
Blog: v20.5.0 release post (#5536)
73a637a 
Refs: nodejs/node#48761
@github-actions github-actions bot mentioned this pull request Jul 21, 2023
Open
16 tasks
rluvaton pushed a commit to rluvaton/node that referenced this pull request Jul 21, 2023
@juanarbol @rluvaton
2023-07-18, Version 20.5.0 (Current)
f00c0a4 
Notable changes:

doc:
  * add atlowChemi to collaborators (atlowChemi) nodejs#48757
events:
  * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) nodejs#48596
fs:
  * add a fast-path for readFileSync utf-8 (Yagiz Nizipli) nodejs#48658
test_runner:
  * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs#48639

PR-URL: nodejs#48761
This was referenced Jul 22, 2023
Open
Open
Open
Open
Open
Open
Open
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@juanarbol
2023-07-18, Version 20.5.0 (Current)
3c8fec1 
Notable changes:

doc:
  * add atlowChemi to collaborators (atlowChemi) nodejs#48757
events:
  * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) nodejs#48596
fs:
  * add a fast-path for readFileSync utf-8 (Yagiz Nizipli) nodejs#48658
test_runner:
  * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs#48639

PR-URL: nodejs#48761
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@juanarbol
2023-07-18, Version 20.5.0 (Current)
0a9e788 
Notable changes:

doc:
  * add atlowChemi to collaborators (atlowChemi) nodejs#48757
events:
  * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) nodejs#48596
fs:
  * add a fast-path for readFileSync utf-8 (Yagiz Nizipli) nodejs#48658
test_runner:
  * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs#48639

PR-URL: nodejs#48761
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@juanarbol @Ceres6
2023-07-18, Version 20.5.0 (Current)
4c6cd1d 
Notable changes:

doc:
  * add atlowChemi to collaborators (atlowChemi) nodejs#48757
events:
  * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) nodejs#48596
fs:
  * add a fast-path for readFileSync utf-8 (Yagiz Nizipli) nodejs#48658
test_runner:
  * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs#48639

PR-URL: nodejs#48761
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@juanarbol @Ceres6
2023-07-18, Version 20.5.0 (Current)
067c4ce 
Notable changes:

doc:
  * add atlowChemi to collaborators (atlowChemi) nodejs#48757
events:
  * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) nodejs#48596
fs:
  * add a fast-path for readFileSync utf-8 (Yagiz Nizipli) nodejs#48658
test_runner:
  * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs#48639

PR-URL: nodejs#48761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.