tools, test: enable assorted ESLint error rules #4864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables assorted rules from the category of possible errors. These should not get in the way in any form. - http://eslint.org/docs/rules/no-control-regex - http://eslint.org/docs/rules/no-extra-boolean-cast - http://eslint.org/docs/rules/no-invalid-regexp - http://eslint.org/docs/rules/no-irregular-whitespace - http://eslint.org/docs/rules/no-unexpected-multiline
silverwind
added
test
|
LGTM |
|
LGTM barring any unforeseen and surprising CI issues |
|
Green CI - LGTM |
silverwind
added a commit
that referenced
this pull request
Jan 26, 2016
Enables assorted rules from the category of possible errors. These should not get in the way in any form. - http://eslint.org/docs/rules/no-control-regex - http://eslint.org/docs/rules/no-extra-boolean-cast - http://eslint.org/docs/rules/no-invalid-regexp - http://eslint.org/docs/rules/no-irregular-whitespace - http://eslint.org/docs/rules/no-unexpected-multiline PR-URL: #4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
silverwind
added a commit
that referenced
this pull request
Jan 26, 2016
PR-URL: #4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jan 27, 2016
Enables assorted rules from the category of possible errors. These should not get in the way in any form. - http://eslint.org/docs/rules/no-control-regex - http://eslint.org/docs/rules/no-extra-boolean-cast - http://eslint.org/docs/rules/no-invalid-regexp - http://eslint.org/docs/rules/no-irregular-whitespace - http://eslint.org/docs/rules/no-unexpected-multiline PR-URL: #4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jan 27, 2016
PR-URL: #4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
benjamingr
pushed a commit
to benjamingr/io.js
that referenced
this pull request
Jan 27, 2016
Enables assorted rules from the category of possible errors. These should not get in the way in any form. - http://eslint.org/docs/rules/no-control-regex - http://eslint.org/docs/rules/no-extra-boolean-cast - http://eslint.org/docs/rules/no-invalid-regexp - http://eslint.org/docs/rules/no-irregular-whitespace - http://eslint.org/docs/rules/no-unexpected-multiline PR-URL: nodejs#4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
benjamingr
pushed a commit
to benjamingr/io.js
that referenced
this pull request
Jan 27, 2016
PR-URL: nodejs#4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
Enables assorted rules from the category of possible errors. These should not get in the way in any form. - http://eslint.org/docs/rules/no-control-regex - http://eslint.org/docs/rules/no-extra-boolean-cast - http://eslint.org/docs/rules/no-invalid-regexp - http://eslint.org/docs/rules/no-irregular-whitespace - http://eslint.org/docs/rules/no-unexpected-multiline PR-URL: #4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
PR-URL: #4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
Enables assorted rules from the category of possible errors. These should not get in the way in any form. - http://eslint.org/docs/rules/no-control-regex - http://eslint.org/docs/rules/no-extra-boolean-cast - http://eslint.org/docs/rules/no-invalid-regexp - http://eslint.org/docs/rules/no-irregular-whitespace - http://eslint.org/docs/rules/no-unexpected-multiline PR-URL: #4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
PR-URL: #4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Enables assorted rules from the category of possible errors. These should not get in the way in any form. - http://eslint.org/docs/rules/no-control-regex - http://eslint.org/docs/rules/no-extra-boolean-cast - http://eslint.org/docs/rules/no-invalid-regexp - http://eslint.org/docs/rules/no-irregular-whitespace - http://eslint.org/docs/rules/no-unexpected-multiline PR-URL: #4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Enables assorted rules from the category of possible errors. These should not get in the way in any form. - http://eslint.org/docs/rules/no-control-regex - http://eslint.org/docs/rules/no-extra-boolean-cast - http://eslint.org/docs/rules/no-invalid-regexp - http://eslint.org/docs/rules/no-irregular-whitespace - http://eslint.org/docs/rules/no-unexpected-multiline PR-URL: #4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
PR-URL: #4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Enables assorted rules from the category of possible errors. These should not get in the way in any form. - http://eslint.org/docs/rules/no-control-regex - http://eslint.org/docs/rules/no-extra-boolean-cast - http://eslint.org/docs/rules/no-invalid-regexp - http://eslint.org/docs/rules/no-irregular-whitespace - http://eslint.org/docs/rules/no-unexpected-multiline PR-URL: nodejs#4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4864 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables assorted ESLint rules from the
Possible Errorscategory. I made sure to choose only rules which won't get in the way of whatever arcane trick someone might want to attempt.no-control-regexno-extra-boolean-castno-invalid-regexpno-irregular-whitespaceno-unexpected-multilinetest-promises-unhandled-rejections.jshad some\u00a0space characters which I fixed.