Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: improve network family autoselection handle handling #48464

Merged
merged 1 commit into from
Jun 27, 2023
Merged

net: improve network family autoselection handle handling #48464

merged 1 commit into from
Jun 27, 2023

Conversation

ShogunPanda
Copy link
Contributor

This PR fixes network family autoselections in three area:

  1. Moves handle swapping before trying a new connection, as suggested in npm ERR! Exit handler never called! npm/cli#6409 (comment)
  2. Avoids spawning two different connection attempts, which could happen if a TLSSocket with a manually set backing Socket was used. See: PSA: If you're on node 20.0.0 and above, and want to use this library with client.configuration.connection.secure === true, use the argument --no-network-family-autoselection KararTY/dank-twitch-irc#13 (comment)
  3. Correctly handles AbortSignal when using network family auto selection.

Fixes: npm/cli#6409
Fixes: KararTY/dank-twitch-irc#13
Fixes: #47644

CC: @tniessen @silverwind

@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2023
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jun 15, 2023
This was referenced Jun 15, 2023
Closed
Closed
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52262/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52263/

mcollina
mcollina approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShogunPanda ShogunPanda mentioned this pull request Jun 19, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
Open
29 tasks
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52340/

@ShogunPanda
Copy link
Contributor Author

I'll check the failing test locally this evening and then I'll update and finally merge this.

@ShogunPanda ShogunPanda force-pushed the network-selection-handle-improvements branch from 5388aa7 to 16ab933 Compare June 26, 2023 07:33
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52487/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52499/

@github-actions github-actions bot mentioned this pull request Jun 27, 2023
Open
24 tasks
@ShogunPanda ShogunPanda added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit fddd3ff into nodejs:main Jun 27, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in fddd3ff

@ShogunPanda ShogunPanda deleted the network-selection-handle-improvements branch June 27, 2023 11:17
This was referenced Jun 28, 2023
Open
Open
Open
Open
@bnoordhuis bnoordhuis mentioned this pull request Jul 1, 2023
Closed
This was referenced Jul 2, 2023
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@ShogunPanda @RafaelGSS
net: improve network family autoselection handle handling
2c36397 
PR-URL: #48464
Fixes: npm/cli#6409
Fixes: KararTY/dank-twitch-irc#13
Fixes: #47644
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
hail2u added a commit to hail2u/hail2u.net that referenced this pull request Jul 16, 2023
@hail2u
Bookmark nodejs/node#48464
8625e85
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ShogunPanda @Ceres6
net: improve network family autoselection handle handling
9ffc304 
PR-URL: nodejs#48464
Fixes: npm/cli#6409
Fixes: KararTY/dank-twitch-irc#13
Fixes: nodejs#47644
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ShogunPanda @Ceres6
net: improve network family autoselection handle handling
f251e28 
PR-URL: nodejs#48464
Fixes: npm/cli#6409
Fixes: KararTY/dank-twitch-irc#13
Fixes: nodejs#47644
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@ShogunPanda ShogunPanda mentioned this pull request Aug 17, 2023
Closed
@ruyadorno
Copy link
Member

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

@ruyadorno ruyadorno added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Sep 10, 2023
@lukekarrys lukekarrys mentioned this pull request Sep 11, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
6 participants
@ShogunPanda @nodejs-github-bot @ruyadorno @mcollina @benjamingr @marco-ippolito