doc: correct line break for Windows terminals #48083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
LGTM, although I wonder if we should just remove the line-wrapping entirely for these commands. |
Trott
approved these changes
May 20, 2023
lpinca
approved these changes
May 20, 2023
Trott
added
commit-queue
RaisinTen
approved these changes
May 20, 2023
RaisinTen
added
the
author ready
Mesteery
approved these changes
May 21, 2023
|
Can this be merged? |
|
Fast-track has been requested by @lpinca. Please 👍 to approve. |
nodejs-github-bot
removed
the
commit-queue
This comment was marked as off-topic.
This comment was marked as off-topic.
nodejs-github-bot
added
the
commit-queue-failed
tniessen
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/48083 ✔ Done loading data for nodejs/node/pull/48083 ----------------------------------- PR info ------------------------------------ Title doc: correct line break for Windows terminals (#48083) Author Alex Schwartz (@alexsch01, first-time contributor) Branch alexsch01:patch-1 -> nodejs:main Labels doc, fast-track, author ready, commit-queue-squash Commits 3 - doc: correct line break for Windows terminals - fixup! doc: correct line break for Windows terminals - fixup! doc: correct line break for Windows terminals Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/48083 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Tobias Nießen Reviewed-By: Mestery Reviewed-By: Claudio Wunder ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48083 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Tobias Nießen Reviewed-By: Mestery Reviewed-By: Claudio Wunder -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 20 May 2023 00:01:20 GMT ✔ Approvals: 6 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435313042 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435361522 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435362880 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435449579 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435512554 ✔ - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435517144 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient ⚠ PR author is a new contributor: @alexsch01([email protected]) ⚠ - commit 5452a24117c8 is authored by [email protected] -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5038315202 |
PR-URL: #48083 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
|
Landed in e49bb68 |
|
Thanks for the contribution! 🎉 |
fasenderos
pushed a commit
to fasenderos/node
that referenced
this pull request
May 22, 2023
PR-URL: nodejs#48083 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
fasenderos
pushed a commit
to fasenderos/node
that referenced
this pull request
May 22, 2023
PR-URL: nodejs#48083 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2023
PR-URL: #48083 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
|
blocked by #47125 |
danielleadams
added
the
backport-blocked-v18.x
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48083 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48083 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows terminals [Command Prompt and PowerShell] don't use \ for line breaks