Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updated process.versions properties #48019

Merged
merged 1 commit into from
May 17, 2023
Merged

doc: updated process.versions properties #48019

merged 1 commit into from
May 17, 2023

Conversation

Basa198
Copy link
Contributor

@Basa198 Basa198 commented May 15, 2023

Added process.versions properties in docs:
uvwasi
undici
acorn
base64
cjs_module_lexer

Before

image

After

image

Fixes: #48016

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels May 15, 2023
@Basa198 Basa198 changed the title docs: updated process.versions properties doc: updated process.versions properties May 15, 2023
Copy link
Member

@debadree25 debadree25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could replace the entire output with what the latest version of node gives?

{
  node: '19.8.1',
  acorn: '8.8.2',
  ada: '1.0.4',
  ares: '1.19.0',
  brotli: '1.0.9',
  cldr: '42.0',
  icu: '72.1',
  llhttp: '8.1.0',
  modules: '111',
  napi: '8',
  nghttp2: '1.52.0',
  openssl: '1.1.1t',
  simdutf: '3.2.2',
  tz: '2022e',
  undici: '5.21.0',
  unicode: '15.0',
  uv: '1.44.2',
  uvwasi: '0.0.16',
  v8: '10.8.168.25-node.12',
  zlib: '1.2.11'
}

There's a small difference that node now prints everything alphabetically ordered

@targos
Copy link
Member

targos commented May 15, 2023

Here's the output with main:

{
  node: '21.0.0-pre',
  acorn: '8.8.2',
  ada: '2.4.0',
  ares: '1.19.0',
  base64: '0.5.0',
  brotli: '1.0.9',
  cjs_module_lexer: '1.2.2',
  cldr: '43.0',
  icu: '73.1',
  llhttp: '8.1.0',
  modules: '115',
  napi: '8',
  nghttp2: '1.52.0',
  nghttp3: '0.7.0',
  ngtcp2: '0.8.1',
  openssl: '3.0.8+quic',
  simdutf: '3.2.9',
  tz: '2023c',
  undici: '5.22.0',
  unicode: '15.0',
  uv: '1.44.2',
  uvwasi: '0.0.16',
  v8: '11.3.244.8-node.9',
  zlib: '1.2.13'
}

I think we should take it and replace '21.0.0-pre' with 20.2.0 (it will contain cjs_module_lexer and base64)

@targos targos added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels May 15, 2023
@Basa198
Copy link
Contributor Author

Basa198 commented May 15, 2023

Thanks for commenting, could you please give more instructions? Should I update the doc/api/process.md with the current versions?

@debadree25
Copy link
Member

Hey! You can just copy and paste @targos soln in the doc

@Basa198
Copy link
Contributor Author

Basa198 commented May 15, 2023

Great! Thank you for being so helpful

Copy link
Contributor

@deokjinkim deokjinkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add below line to commit message? With below line, issue will be closed automatically if this PR is merged.

Fixes: https://github.com/nodejs/node/issues/48016

You can find detail guideline below.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

icu: '63.1',
tz: '2018e',
unicode: '11.0' }
{ node: '21.0.0-pre',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @targos mentioned, please replace '21.0.0-pre' with 20.2.0.

Suggested change
{ node: '21.0.0-pre',
{ node: '20.2.0',

Copy link
Contributor

@deokjinkim deokjinkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add below line to commit message? With below line, issue will be closed automatically if this PR is merged.

Fixes: https://github.com/nodejs/node/issues/48016

You can find detail guideline below.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

@Basa198
Copy link
Contributor Author

Basa198 commented May 15, 2023

Thanks for input, anything else?

@deokjinkim
Copy link
Contributor

Thanks for input, anything else?

For now, first commit's subsystem(docs => doc) is wrong. So, need to change commit title to doc: update process.versions properties. And there are 3 commits, so I recommend you squash 3 commits into 1 because first commit title has violation.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 15, 2023
@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1fdcb1c into nodejs:main May 17, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 1fdcb1c

@Basa198 Basa198 deleted the docsUpdatedprocess.versions branch May 25, 2023 14:29
targos pushed a commit that referenced this pull request May 30, 2023
Fixes: #48016
PR-URL: #48019
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation of process.versions should be updated
10 participants