-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: updated process.versions properties #48019
doc: updated process.versions properties #48019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could replace the entire output with what the latest version of node gives?
{
node: '19.8.1',
acorn: '8.8.2',
ada: '1.0.4',
ares: '1.19.0',
brotli: '1.0.9',
cldr: '42.0',
icu: '72.1',
llhttp: '8.1.0',
modules: '111',
napi: '8',
nghttp2: '1.52.0',
openssl: '1.1.1t',
simdutf: '3.2.2',
tz: '2022e',
undici: '5.21.0',
unicode: '15.0',
uv: '1.44.2',
uvwasi: '0.0.16',
v8: '10.8.168.25-node.12',
zlib: '1.2.11'
}
There's a small difference that node now prints everything alphabetically ordered
Here's the output with
I think we should take it and replace |
Thanks for commenting, could you please give more instructions? Should I update the |
Hey! You can just copy and paste @targos soln in the doc |
Great! Thank you for being so helpful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add below line to commit message? With below line, issue will be closed automatically if this PR is merged.
Fixes: https://github.com/nodejs/node/issues/48016
You can find detail guideline below.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines
doc/api/process.md
Outdated
icu: '63.1', | ||
tz: '2018e', | ||
unicode: '11.0' } | ||
{ node: '21.0.0-pre', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @targos mentioned, please replace '21.0.0-pre' with 20.2.0.
{ node: '21.0.0-pre', | |
{ node: '20.2.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add below line to commit message? With below line, issue will be closed automatically if this PR is merged.
Fixes: https://github.com/nodejs/node/issues/48016
You can find detail guideline below.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines
Thanks for input, anything else? |
For now, first commit's subsystem( |
Landed in 1fdcb1c |
Fixes: #48016 PR-URL: #48019 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Added process.versions properties in docs:
uvwasi
undici
acorn
base64
cjs_module_lexer
Before
After
Fixes: #48016