-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: add security-wg ping to permission.js #47941
meta: add security-wg ping to permission.js #47941
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM. FWIW, do we think that the Ecosystem Security Working Group is the best group to review these changes?
Permission Model is one of the Security WG initiatives, so yes. Btw, there is no Ecosystem Security WG anymore. Just Security WG. |
@RafaelGSS Sorry, I am a little confused. The README in https://github.com/nodejs/security-wg still says "Ecosystem Security WG". That WG seems to have been dechartered in nodejs/TSC#1351. Then there is nodejs/security-wg#874, which replaces "Ecosystem Security WG" with "Security WG," but my understanding is that it is just a regular GitHub team now and not actually a WG. Is that correct or am I missing something? |
Yes, it's supposed to be a team instead of a WG. That was one of @mhdawson requests in that PR nodejs/security-wg#874 (comment). Security WG seems easy to share at least. I'll include it in the agenda tomorrow. |
Landed in 745083a |
PR-URL: #47941 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #47941 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #47941 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#47941 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
No description provided.