Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add security-wg ping to permission.js #47941

Merged

Conversation

RafaelGSS
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 9, 2023
@daeyeon daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2023
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM. FWIW, do we think that the Ecosystem Security Working Group is the best group to review these changes?

@RafaelGSS
Copy link
Member Author

RSLGTM. FWIW, do we think that the Ecosystem Security Working Group is the best group to review these changes?

Permission Model is one of the Security WG initiatives, so yes.

Btw, there is no Ecosystem Security WG anymore. Just Security WG.

@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2023
@tniessen
Copy link
Member

Btw, there is no Ecosystem Security WG anymore. Just Security WG.

@RafaelGSS Sorry, I am a little confused. The README in https://github.com/nodejs/security-wg still says "Ecosystem Security WG". That WG seems to have been dechartered in nodejs/TSC#1351. Then there is nodejs/security-wg#874, which replaces "Ecosystem Security WG" with "Security WG," but my understanding is that it is just a regular GitHub team now and not actually a WG. Is that correct or am I missing something?

@RafaelGSS
Copy link
Member Author

Yes, it's supposed to be a team instead of a WG. That was one of @mhdawson requests in that PR nodejs/security-wg#874 (comment).

Security WG seems easy to share at least. I'll include it in the agenda tomorrow.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit 745083a into nodejs:main May 11, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 745083a

targos pushed a commit that referenced this pull request May 12, 2023
PR-URL: #47941
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 15, 2023
PR-URL: #47941
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47941
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47941
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@tniessen tniessen added the permission Issues and PRs related to the Permission Model label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project. permission Issues and PRs related to the Permission Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants