Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix test hooks order in subtests to match describe suites #47916

Closed
wants to merge 1 commit into from
Closed

test_runner: fix test hooks order in subtests to match describe suites #47916

wants to merge 1 commit into from

Conversation

mertcanaltin
Copy link
Member

fix test hooks order in subtests to match describe suites

issue: #47915

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 8, 2023
@MoLow
Copy link
Member

MoLow commented May 8, 2023

I am not sure what this PR fixes. changing this test will no fix the bug reported in #47915

@mertcanaltin
Copy link
Member Author

I am not sure what this PR fixes. changing this test will no fix the bug reported in #47915

ah sorry I thought when the test hooks weren't lined up correctly it might cause the tests to run incorrectly @MoLow

@mertcanaltin
Copy link
Member Author

I'm closing this pr thank you very much @MoLow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mertcanaltin @MoLow @nodejs-github-bot