Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix --require with --experimental-loader #47751

Merged
merged 1 commit into from
Apr 29, 2023
Merged

test_runner: fix --require with --experimental-loader #47751

merged 1 commit into from
Apr 29, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Apr 27, 2023 •
edited
Loading

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 27, 2023
@MoLow
Copy link
Member Author

MoLow commented Apr 27, 2023

CC @nodejs/loaders

GeoffreyBooth
GeoffreyBooth reviewed Apr 27, 2023
View reviewed changes
test/fixtures/test-runner/esm/bootloader.js Outdated Show resolved Hide resolved
src/api/environment.cc Show resolved Hide resolved
test/parallel/test-runner-cli.js Outdated Show resolved Hide resolved
test/fixtures/test-runner/esm/loader.mjs Outdated Show resolved Hide resolved
test/parallel/test-runner-cli.js Outdated Show resolved Hide resolved
@MoLow MoLow changed the title test_runner: fix --require with --experimental-loader test_runner: fix --require with --experimental-loader Apr 27, 2023
JakobJingleheimer
JakobJingleheimer approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah! Thanks for this!

Approving presumptively as the core change of this PR is 👍

test/fixtures/test-runner/esm/loader.mjs Outdated Show resolved Hide resolved
@GeoffreyBooth GeoffreyBooth added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2023
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51547/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1300ed0 into nodejs:main Apr 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 1300ed0

@MoLow MoLow deleted the loader-and-require branch April 30, 2023 03:56
targos pushed a commit that referenced this pull request May 2, 2023
@MoLow @targos
test_runner: fix --require with --experimental-loader
3618d31 
PR-URL: #47751
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request May 2, 2023
Merged
targos pushed a commit that referenced this pull request May 3, 2023
@MoLow @targos
test_runner: fix --require with --experimental-loader
e5251e3 
PR-URL: #47751
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow @danielleadams
test_runner: fix --require with --experimental-loader
838803c 
PR-URL: #47751
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test_runner: fix --require with --experimental-loader
8398bca 
PR-URL: nodejs#47751
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MoLow @nodejs-github-bot @GeoffreyBooth @JakobJingleheimer @aduh95