Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix update-v8-patch cache #47725

Merged
merged 1 commit into from
Apr 26, 2023
Merged

tools: fix update-v8-patch cache #47725

merged 1 commit into from
Apr 26, 2023

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Apr 26, 2023 •
edited
Loading

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 26, 2023
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 26, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 26, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/47725
✔  Done loading data for nodejs/node/pull/47725
----------------------------------- PR info ------------------------------------
Title      tools: fix update-v8-patch cache (#47725)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:fix/v8-cache-update -> nodejs:main
Labels     meta, fast-track
Commits    1
 - tools: fix update-v8-patch cache
Committers 1
 - Marco Ippolito 
PR-URL: https://github.com/nodejs/node/pull/47725
Fixes: https://github.com/nodejs/node/actions/runs/4807223999/jobs/8555708692
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47725
Fixes: https://github.com/nodejs/node/actions/runs/4807223999/jobs/8555708692
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 26 Apr 2023 10:37:55 GMT
   ✔  Approvals: 2
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47725#pullrequestreview-1401760300
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/47725#pullrequestreview-1401964994
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 47725
From https://github.com/nodejs/node
 * branch                  refs/pull/47725/merge -> FETCH_HEAD
✔  Fetched commits as 76044c4e2b6a..289210191123
--------------------------------------------------------------------------------
[main 3cc155d32e] tools: fix update-v8-patch cache
 Author: Marco Ippolito 
 Date: Wed Apr 26 12:36:51 2023 +0200
 1 file changed, 6 insertions(+), 2 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
tools: fix update-v8-patch cache

PR-URL: #47725

Fixes: https://github.com/nodejs/node/actions/runs/4807223999/jobs/8555708692

Reviewed-By: Richard Lau [email protected]

Reviewed-By: Michaël Zasso [email protected]


[main bb52f5ba59] tools: fix update-v8-patch cache

Author: Marco Ippolito [email protected]

Date: Wed Apr 26 12:36:51 2023 +0200

1 file changed, 6 insertions(+), 2 deletions(-)

✖  bb52f5ba59b5c0a6d84d3a05815ae907d172b20f

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✖  2:7      Fixes must be a GitHub URL.               fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length


ℹ  Please fix the commit message and try again.

Please manually ammend the commit message, by running

git commit --amend

Once commit message is fixed, finish the landing command running

git node land --continue
https://github.com/nodejs/node/actions/runs/4809328695

@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit ad5a0d1 into nodejs:main Apr 26, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in ad5a0d1

@targos
Copy link
Member

targos commented Apr 26, 2023

New run: https://github.com/nodejs/node/actions/runs/4809435628

yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
@marco-ippolito @yjl9903
tools: fix update-v8-patch cache
0d8a0a6 
PR-URL: nodejs#47725
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
@marco-ippolito @yjl9903
tools: fix update-v8-patch cache
a9ef18c 
PR-URL: nodejs#47725
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
@marco-ippolito @yjl9903
tools: fix update-v8-patch cache
885441e 
PR-URL: nodejs#47725
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request May 2, 2023
@marco-ippolito @targos
tools: fix update-v8-patch cache
9d0bef6 
PR-URL: #47725
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito @danielleadams
tools: fix update-v8-patch cache
e0bb400 
PR-URL: #47725
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@marco-ippolito @MoLow
tools: fix update-v8-patch cache
5ee5543 
PR-URL: nodejs#47725
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marco-ippolito @nodejs-github-bot @targos @richardlau