deps: V8: cherry-pick 8e10685ff918 #47440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message:
[build]: fix wrong name
Change-Id: I504e836da1e36d7b9e504dbdbff8803363f08ccd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4392064
Reviewed-by: Tobias Tebbi <[email protected]>
Commit-Queue: Tobias Tebbi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#86919}
Refs: v8/v8@8e10685
|
Review requested:
|
nodejs-github-bot
added
build
gengjiawen
added
request-ci
github-actions
bot
removed
the
request-ci
gengjiawen
added
v8 engine
targos
approved these changes
Apr 8, 2023
targos
added
the
author ready
richardlau
approved these changes
Apr 11, 2023
Trott
approved these changes
Apr 11, 2023
gengjiawen
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47440 ✔ Done loading data for nodejs/node/pull/47440 ----------------------------------- PR info ------------------------------------ Title deps: V8: cherry-pick 8e10685ff918 (#47440) Author Jiawen Geng (@gengjiawen) Branch gengjiawen:v8/pick -> nodejs:main Labels build, v8 engine, author ready, needs-ci Commits 1 - deps: V8: cherry-pick 8e10685ff918 Committers 1 - Jiawen Geng PR-URL: https://github.com/nodejs/node/pull/47440 Refs: https://github.com/v8/v8/commit/8e10685ff9187ab1b4041a1b320dc6012c09c460 Reviewed-By: Michaël Zasso Reviewed-By: Richard Lau Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47440 Refs: https://github.com/v8/v8/commit/8e10685ff9187ab1b4041a1b320dc6012c09c460 Reviewed-By: Michaël Zasso Reviewed-By: Richard Lau Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 06 Apr 2023 02:09:00 GMT ✔ Approvals: 3 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/47440#pullrequestreview-1376735937 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47440#pullrequestreview-1379058117 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47440#pullrequestreview-1379131272 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-04-11T14:32:53Z: https://ci.nodejs.org/job/node-test-pull-request/51133/ - Querying data for job/node-test-pull-request/51133/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4670174219 |
debadree25
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4bcb42c |
targos
pushed a commit
that referenced
this pull request
May 2, 2023
Original commit message:
[build]: fix wrong name
Change-Id: I504e836da1e36d7b9e504dbdbff8803363f08ccd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4392064
Reviewed-by: Tobias Tebbi <[email protected]>
Commit-Queue: Tobias Tebbi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#86919}
Refs: v8/v8@8e10685
PR-URL: #47440
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams
added
the
dont-land-on-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@8e10685