src: use correct variable in node_builtins.cc #47343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
approved these changes
Mar 31, 2023
cjihrig
approved these changes
Mar 31, 2023
legendecas
approved these changes
Mar 31, 2023
lpinca
approved these changes
Mar 31, 2023
jasnell
approved these changes
Mar 31, 2023
joyeecheung
reviewed
Apr 1, 2023
There was a problem hiding this comment.
This should be fixed by making L589 and L595 use builtins_in_snapshot_js instead. Somehow we ended up using builtins_without_cache_js for them, which is technically okay, because it then acts like a temporary handle that gets reused and pointed to another V8 value, but the handle that's meant to be used is actually builtins_in_snapshot_js. Keeping using a handle that's named builtins_without_cache_js for compiledInSnapshot would be confusing.
|
@joyeecheung feel free to open an alternative PR. Otherwise I'll update this one on Monday |
targos
force-pushed
the
rm-builtins_in_snapshot_js
branch
from
6cdbeed
to
eaf854e
Compare
|
Updated |
targos
changed the title
legendecas
approved these changes
Apr 4, 2023
|
Though I'm thinking that maybe we don't need three intermediate local handles -- single local handle seems pretty sufficient in the case. |
joyeecheung
approved these changes
Apr 4, 2023
github-actions
bot
removed
the
request-ci
|
BTW, any idea on why the |
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 25ad49b |
targos
added a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47343 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47343 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47343 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.