stream: allow stream to stay open after take #47023
+92
−9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ const { | |
| validateAbortSignal, | ||
| validateInteger, | ||
| validateObject, | ||
| validateBoolean, | ||
| } = require('internal/validators'); | ||
| const { kWeakHandler } = require('internal/event_target'); | ||
| const { finished } = require('internal/streams/end-of-stream'); | ||
|
|
@@ -397,13 +398,16 @@ function take(number, options = undefined) { | |
| if (options?.signal != null) { | ||
| validateAbortSignal(options.signal, 'options.signal'); | ||
| } | ||
| if (options?.destroyStream != null) { | ||
| validateBoolean(options.destroyStream, 'options.destroyStream'); | ||
| } | ||
|
|
||
| number = toIntegerOrInfinity(number); | ||
| return async function* take() { | ||
| if (options?.signal?.aborted) { | ||
| throw new AbortError(); | ||
| } | ||
| for await (const val of this.iterator({ destroyOnReturn: options?.destroyStream ?? true })) { | ||
| if (options?.signal?.aborted) { | ||
| throw new AbortError(); | ||
| } | ||
|
There was a problem hiding this comment. I think that if the stream fails we should close the stream, WDYT @ronag ? There was a problem hiding this comment. @mcollina any thoughts on your side? There was a problem hiding this comment. after thinking I think it should be closed on an error as in the iterator helpers proposal spec the underlying iterator should be closed when it failed |
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe another name would be better? Not sure what though... @benjamingr