Remove --ninja and --xcode configure options #467
Conversation
|
/cc @thlorenz are you using the xcode config of from core? |
|
@bnoordhuis does removing Ninja make it difficult at all if we ended up opting to embrace gn? |
|
Actually that's provably a silly question, ignore that. |
|
LGTM pending @thlorenz's yea or nay re: xcode. At the very least I don't foresee any tears shed over the loss of ninja support – no matter what, that can probably go. |
|
what exactly is the benefit of killing off ninja here? (and, pro-xcode, it's less of a pain to debug the repl in xcode, no need to worry about capturing SIGTTIN and friends, it's just easier on people) |
|
@caitp The motivation is described in the commit log. In a nutshell, it's uncertain if people actually use it. The --xcode flag was added because of nodejs/node-v0.x-archive#4020 (I think.) The goal there was to create fat binaries but the flag isn't used for that. That said, it's not much work to keep it around if people actually use it. |
|
@thlorenz is doing some crazy stuff with xcode & node, e.g. nad, but I'm not sure if his work extends to core, I'm waiting on feedback from him but we may have to wait until next week for that. @bnoordhuis I'm +1 on the ninja removal but -1 on xcode removal pending @thlorenz' feedback. |
It is unknown if there are any users of the ninja build and keeping it around makes refactoring the build system more difficult. It's partly broken (or at least, deeply inefficient) because it touches out/Makefile every time. PR-URL: #467 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Added in commit ac04716 without explanation or bug number. Unclear if there are users. Remove, reinstate if users complain.
bnoordhuis
force-pushed
the
remove-configure-options
branch
from
875509d
to
b7400c6
Compare
|
@caitp Forgot to mention, if support for ninja is truly a desired feature, there are better ways to integrate it into the build. The way it was done before just wasn't very great. |
|
as noted by others, since gn isn't really available to people easily without chromium, there's not a very great way to integrate ninja yet apart from what (was) already in the tree. As for xcode, I'm already using this to simplify llvm debugging (the output in the integrated terminal looks awful, but at least it works without dealing with llvm annoyingness), I expect I'm not the only one |
|
Okay, let's keep it. Closing the PR. |
|
Maybe too late, but FWIW I'm a big fan of also keeping the ninja generator around. Seeing that the |
|
@thlorenz |
|
Thanks. |
Ninja is a build backend supported by gyp which is much faster than Make and is able to parallelize builds across all of the available cores very well. On my machine, this reduces the average build time from 5:14 minutes to 4:33 minutes. Refs: nodejs#467 Refs: de224d6 PR-URL: nodejs#6780 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Ninja is a build backend supported by gyp which is much faster than Make and is able to parallelize builds across all of the available cores very well. On my machine, this reduces the average build time from 5:14 minutes to 4:33 minutes. Refs: nodejs#467 Refs: de224d6 PR-URL: nodejs#6780 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Ninja is a build backend supported by gyp which is much faster than Make and is able to parallelize builds across all of the available cores very well. On my machine, this reduces the average build time from 5:14 minutes to 4:33 minutes. Refs: #467 Refs: de224d6 PR-URL: #6780 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Ninja is a build backend supported by gyp which is much faster than Make and is able to parallelize builds across all of the available cores very well. On my machine, this reduces the average build time from 5:14 minutes to 4:33 minutes. Refs: #467 Refs: de224d6 PR-URL: #6780 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Ninja is a build backend supported by gyp which is much faster than Make and is able to parallelize builds across all of the available cores very well. On my machine, this reduces the average build time from 5:14 minutes to 4:33 minutes. Refs: #467 Refs: de224d6 PR-URL: #6780 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Ninja is a build backend supported by gyp which is much faster than Make and is able to parallelize builds across all of the available cores very well. On my machine, this reduces the average build time from 5:14 minutes to 4:33 minutes. Refs: #467 Refs: de224d6 PR-URL: #6780 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Ninja is a build backend supported by gyp which is much faster than Make and is able to parallelize builds across all of the available cores very well. On my machine, this reduces the average build time from 5:14 minutes to 4:33 minutes. Refs: #467 Refs: de224d6 PR-URL: #6780 Reviewed-By: Jeremiah Senkpiel <[email protected]>
R=@chrisdickinson?