assert,util: improve comparison performance #46593

BridgeAR · 2023-02-09T21:43:28Z

benchmark: rework assert benchmarks for correctness

This reworks most assert benchmarks to provide more reliable test
cases that also test more cases than before while keeping the
runtime low.

test: remove obsolete util.isDeepStrictEqual tests

These tests are a copy of the assert tests that verify the
deep equal comparison algorithm. There is no need to duplicate the
tests as changing one would require to change the tests in two
places without knowing which ones to actually rely upon.

assert,util: improve deep equal comparison performance

This is mainly a performance improvement for a lot of simple cases.
Diverging elements are detected earlier and equal entries are
partially also detected faster.

A small correctness patch is also included where recursions now
stop as soon as either side has a circular structure. Before, both
sides had to have a circular structure at the specific comparison
which could have caused more checks that likely fail at a later
point.

Signed-off-by: Ruben Bridgewater [email protected]

Benchmark

                                                                                                                      confidence improvement accuracy (*)   (**)   (***)
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=0 strict=0 len=100 n=20000                                          **      3.84 %       ±2.48% ±3.29%  ±4.25%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=0 strict=0 len=1000 n=20000                                         **      3.18 %       ±2.27% ±3.00%  ±3.89%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=0 strict=1 len=100 n=20000                                           *      2.93 %       ±2.41% ±3.20%  ±4.14%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=0 strict=1 len=1000 n=20000                                                 0.92 %       ±2.28% ±3.03%  ±3.91%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=1 strict=0 len=100 n=20000                                           *      3.23 %       ±3.13% ±4.16%  ±5.40%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=1 strict=0 len=1000 n=20000                                                -0.92 %       ±4.38% ±5.81%  ±7.52%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=1 strict=1 len=100 n=20000                                                  1.98 %       ±2.31% ±3.06%  ±3.95%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=1 strict=1 len=1000 n=20000                                         **      3.30 %       ±2.27% ±3.01%  ±3.89%
assert/deepequal-buffer.js method='notDeepEqual' arrayBuffer=0 strict=1 len=100 n=20000                                      ***      5.99 %       ±3.09% ±4.10%  ±5.31%
assert/deepequal-buffer.js method='notDeepEqual' arrayBuffer=0 strict=1 len=1000 n=20000                                     ***      6.81 %       ±2.59% ±3.45%  ±4.47%
assert/deepequal-buffer.js method='notDeepEqual' arrayBuffer=1 strict=1 len=100 n=20000                                               0.76 %       ±3.18% ±4.22%  ±5.48%
assert/deepequal-buffer.js method='notDeepEqual' arrayBuffer=1 strict=1 len=1000 n=20000                                       *     -3.71 %       ±3.21% ±4.28%  ±5.57%
assert/deepequal-buffer.js method='unequal_length' arrayBuffer=0 strict=1 len=100 n=20000                                    ***      8.82 %       ±2.55% ±3.38%  ±4.37%
assert/deepequal-buffer.js method='unequal_length' arrayBuffer=0 strict=1 len=1000 n=20000                                   ***      7.09 %       ±2.85% ±3.77%  ±4.88%
assert/deepequal-buffer.js method='unequal_length' arrayBuffer=1 strict=1 len=100 n=20000                                             0.20 %       ±2.67% ±3.53%  ±4.57%
assert/deepequal-buffer.js method='unequal_length' arrayBuffer=1 strict=1 len=1000 n=20000                                            1.87 %       ±2.99% ±3.96%  ±5.13%
assert/deepequal-map.js method='deepEqual_mixed' strict=0 len=500 n=500                                                      ***     19.51 %       ±1.73% ±2.29%  ±2.96%
assert/deepequal-map.js method='deepEqual_mixed' strict=1 len=500 n=500                                                      ***     20.58 %       ±1.75% ±2.32%  ±3.00%
assert/deepequal-map.js method='deepEqual_objectOnly' strict=0 len=500 n=500                                                 ***     20.77 %       ±1.87% ±2.48%  ±3.20%
assert/deepequal-map.js method='deepEqual_objectOnly' strict=1 len=500 n=500                                                 ***     22.47 %       ±1.72% ±2.28%  ±2.96%
assert/deepequal-map.js method='deepEqual_primitiveOnly' strict=0 len=500 n=500                                                       1.78 %       ±2.61% ±3.46%  ±4.48%
assert/deepequal-map.js method='deepEqual_primitiveOnly' strict=1 len=500 n=500                                                       0.79 %       ±2.49% ±3.30%  ±4.27%
assert/deepequal-map.js method='notDeepEqual_mixed' strict=0 len=500 n=500                                                   ***     56.17 %       ±5.56% ±7.38%  ±9.55%
assert/deepequal-map.js method='notDeepEqual_mixed' strict=1 len=500 n=500                                                   ***     45.24 %       ±6.05% ±8.03% ±10.41%
assert/deepequal-map.js method='notDeepEqual_objectOnly' strict=0 len=500 n=500                                              ***     18.69 %       ±2.56% ±3.39%  ±4.38%
assert/deepequal-map.js method='notDeepEqual_objectOnly' strict=1 len=500 n=500                                              ***     17.77 %       ±2.03% ±2.69%  ±3.48%
assert/deepequal-map.js method='notDeepEqual_primitiveOnly' strict=0 len=500 n=500                                                    1.24 %       ±2.48% ±3.29%  ±4.26%
assert/deepequal-map.js method='notDeepEqual_primitiveOnly' strict=1 len=500 n=500                                                    2.57 %       ±3.30% ±4.37%  ±5.65%
assert/deepequal-object.js method='deepEqual' strict=1 size=100 n=2000                                                       ***      3.69 %       ±1.41% ±1.87%  ±2.42%
assert/deepequal-object.js method='deepEqual' strict=1 size=1000 n=200                                                       ***      4.32 %       ±1.22% ±1.61%  ±2.08%
assert/deepequal-object.js method='deepEqual' strict=1 size=10000 n=25                                                       ***      4.20 %       ±1.21% ±1.60%  ±2.07%
assert/deepequal-object.js method='notDeepEqual' strict=1 size=100 n=2000                                                    ***     -6.46 %       ±3.16% ±4.20%  ±5.45%
assert/deepequal-object.js method='notDeepEqual' strict=1 size=1000 n=200                                                            -1.87 %       ±7.45% ±9.89% ±12.85%
assert/deepequal-object.js method='notDeepEqual' strict=1 size=10000 n=25                                                    ***    -10.13 %       ±5.38% ±7.13%  ±9.24%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='array'                           ***     63.57 %       ±2.67% ±3.53%  ±4.58%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='boolean'                           *      3.52 %       ±3.40% ±4.50%  ±5.84%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='circular'                        ***     83.55 %       ±3.85% ±5.13%  ±6.70%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='date'                                     1.78 %       ±2.62% ±3.47%  ±4.48%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='empty_object'                             1.91 %       ±3.34% ±4.43%  ±5.75%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='number'                                   0.44 %       ±3.82% ±5.06%  ±6.54%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='object_other_property'                   -1.74 %       ±4.14% ±5.49%  ±7.10%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='object'                          ***    106.78 %       ±2.99% ±3.98%  ±5.18%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='regexp'                            *      2.69 %       ±2.34% ±3.10%  ±4.01%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='set_object'                      ***     77.80 %       ±2.95% ±3.91%  ±5.08%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='set_simple'                      ***     87.92 %       ±3.13% ±4.16%  ±5.38%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='string'                                  -1.14 %       ±3.42% ±4.53%  ±5.85%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='array'                           ***     60.87 %       ±2.81% ±3.74%  ±4.86%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='boolean'                          **     -4.95 %       ±3.72% ±4.94%  ±6.41%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='circular'                        ***     40.07 %       ±2.48% ±3.29%  ±4.26%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='date'                                     0.51 %       ±1.83% ±2.42%  ±3.13%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='empty_object'                            -0.05 %       ±1.91% ±2.53%  ±3.27%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='number'                           **      4.42 %       ±3.04% ±4.03%  ±5.21%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='object_other_property'                    0.85 %       ±3.48% ±4.61%  ±5.96%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='object'                          ***     60.84 %       ±3.61% ±4.79%  ±6.22%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='regexp'                            *      3.24 %       ±2.61% ±3.46%  ±4.48%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='set_object'                      ***     60.77 %       ±2.76% ±3.66%  ±4.75%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='set_simple'                      ***     57.80 %       ±2.15% ±2.86%  ±3.70%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='string'                                  -1.97 %       ±3.26% ±4.32%  ±5.59%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='array'                        ***     61.67 %       ±2.62% ±3.48%  ±4.52%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='boolean'                               0.04 %       ±3.64% ±4.83%  ±6.24%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='circular'                     ***     45.44 %       ±3.45% ±4.59%  ±5.95%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='date'                                  1.25 %       ±3.52% ±4.66%  ±6.03%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='empty_object'                   *      3.10 %       ±3.03% ±4.01%  ±5.19%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='number'                         *      4.24 %       ±3.88% ±5.14%  ±6.64%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='object_other_property'                 1.20 %       ±3.77% ±4.99%  ±6.45%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='object'                               -0.80 %       ±3.64% ±4.84%  ±6.32%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='regexp'                                2.16 %       ±2.22% ±2.95%  ±3.82%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='set_object'                   ***     52.14 %       ±2.40% ±3.19%  ±4.13%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='set_simple'                   ***     56.10 %       ±3.01% ±4.00%  ±5.18%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='string'                               -0.89 %       ±4.20% ±5.56%  ±7.20%
assert/deepequal-set.js method='deepEqual_mixed' strict=0 len=500 n=500                                                      ***     18.11 %       ±2.45% ±3.25%  ±4.20%
assert/deepequal-set.js method='deepEqual_mixed' strict=1 len=500 n=500                                                      ***     18.87 %       ±2.13% ±2.82%  ±3.65%
assert/deepequal-set.js method='deepEqual_objectOnly' strict=0 len=500 n=500                                                 ***     22.78 %       ±2.27% ±3.00%  ±3.89%
assert/deepequal-set.js method='deepEqual_objectOnly' strict=1 len=500 n=500                                                 ***     20.37 %       ±2.16% ±2.87%  ±3.71%
assert/deepequal-set.js method='deepEqual_primitiveOnly' strict=0 len=500 n=500                                              ***      6.36 %       ±3.27% ±4.35%  ±5.64%
assert/deepequal-set.js method='deepEqual_primitiveOnly' strict=1 len=500 n=500                                              ***      9.87 %       ±2.51% ±3.32%  ±4.30%
assert/deepequal-set.js method='notDeepEqual_mixed' strict=0 len=500 n=500                                                   ***     12.85 %       ±4.26% ±5.65%  ±7.31%
assert/deepequal-set.js method='notDeepEqual_mixed' strict=1 len=500 n=500                                                   ***     35.77 %       ±5.82% ±7.72% ±10.00%
assert/deepequal-set.js method='notDeepEqual_objectOnly' strict=0 len=500 n=500                                              ***     17.64 %       ±2.44% ±3.23%  ±4.18%
assert/deepequal-set.js method='notDeepEqual_objectOnly' strict=1 len=500 n=500                                              ***     13.59 %       ±2.30% ±3.05%  ±3.96%
assert/deepequal-set.js method='notDeepEqual_primitiveOnly' strict=0 len=500 n=500                                             *      2.90 %       ±2.60% ±3.44%  ±4.45%
assert/deepequal-set.js method='notDeepEqual_primitiveOnly' strict=1 len=500 n=500                                           ***     10.72 %       ±2.58% ±3.42%  ±4.42%
assert/deepequal-simple-array-and-set.js method='deepEqual_Array' strict=0 len=20000 n=25                                             0.02 %       ±4.40% ±5.82%  ±7.53%
assert/deepequal-simple-array-and-set.js method='deepEqual_Array' strict=1 len=20000 n=25                                            -1.03 %       ±2.78% ±3.69%  ±4.78%
assert/deepequal-simple-array-and-set.js method='deepEqual_Set' strict=0 len=20000 n=25                                      ***      6.75 %       ±2.79% ±3.70%  ±4.80%
assert/deepequal-simple-array-and-set.js method='deepEqual_Set' strict=1 len=20000 n=25                                      ***      5.23 %       ±2.90% ±3.84%  ±4.98%
assert/deepequal-simple-array-and-set.js method='notDeepEqual_Array' strict=0 len=20000 n=25                                  **     -3.90 %       ±2.70% ±3.57%  ±4.62%
assert/deepequal-simple-array-and-set.js method='notDeepEqual_Array' strict=1 len=20000 n=25                                  **     -3.29 %       ±2.45% ±3.25%  ±4.22%
assert/deepequal-simple-array-and-set.js method='notDeepEqual_Set' strict=0 len=20000 n=25                                           -1.71 %       ±3.13% ±4.15%  ±5.37%
assert/deepequal-simple-array-and-set.js method='notDeepEqual_Set' strict=1 len=20000 n=25                                   ***      7.96 %       ±2.84% ±3.77%  ±4.87%

BridgeAR · 2023-02-10T22:58:44Z

I am not really certain whom to ask for a review here. Maybe @anonrig, @jasnell, @mcollina and @ronag due to being interested in performance things? If that helps, I can also move the change into an own commit and have that reviewed separately.

anonrig

lgtm. thanks for the mention. always a pleasure to review a performance pull request

mcollina

lgtm

targos · 2023-02-11T13:28:19Z

What's the semver-major part of the change (so we can explain it in the v20 changelog)?

BridgeAR · 2023-02-11T13:37:09Z

What's the semver-major part of the change (so we can explain it in the v20 changelog)?

A small correctness patch is included that causes recursions to
stop as soon as either side detects a circular structure. Before, both
sides had to have a circular structure at the specific comparison point
which could have caused more checks while likely failing at a later
point.

This passed so far and is now going to fail:

const a = {};
a.a = a;

const b = {};
b.a = {};
b.a.a = a;

assert.deepStrictEqual(a, b);

BridgeAR · 2023-02-14T23:02:41Z

I included one more commit that actually reverts the breaking change. This allows to backport the overall PR and to include the fix right afterwards as semver major without a hassle.

mcollina

lgtm

BridgeAR · 2023-02-17T00:05:21Z

Benchmark: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1295/

nodejs-github-bot · 2023-02-17T06:10:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49604/

nodejs-github-bot · 2023-02-17T13:25:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49632/

nodejs-github-bot · 2023-02-17T18:35:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49649/

nodejs-github-bot · 2023-02-17T22:02:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49663/

nodejs-github-bot · 2023-02-18T03:16:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49672/

BridgeAR · 2023-02-20T11:44:43Z

@nodejs/node-core-utils does anyone know why the commit-queue is not triggered with the applied labels? Is there maybe a trick to get the commit-queue to run for this PR that I missed?

targos · 2023-02-20T12:25:28Z

See https://github.com/nodejs/node/actions/runs/4223308992/jobs/7332895355

pr 46593 skipped, CI still running

BridgeAR · 2023-02-20T14:40:40Z

@targos seems like the detection solely relies upon the reported state here and that is not always correct.

This reworks most assert benchmarks to provide more reliable test cases that also test more cases than before while keeping the runtime low. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: nodejs#46593 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

These tests are a copy of the assert tests that verify the deep equal comparison algorithm. There is no need to duplicate the tests as changing one would require to change the tests in two places without knowing which ones to actually rely upon. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: nodejs#46593 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

This is mainly a performance improvement for a lot of simple cases. Diverging elements are detected earlier and equal entries are partially also detected faster. A small correctness patch is also included where recursions now stop as soon as either side has a circular structure. Before, both sides had to have a circular structure at the specific comparison which could have caused more checks that likely fail at a later point. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: nodejs#46593 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

This commit is there to be reverted after merging. It makes it easy to backport the overall PR and allows easy forward fixing. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: nodejs#46593 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

aduh95 · 2023-02-20T14:48:26Z

Landed in 1d5058d...575784b

juanarbol · 2023-03-01T20:55:08Z

This is not landing cleanly on v18.x, would lyo umind to rebase?

This reworks most assert benchmarks to provide more reliable test cases that also test more cases than before while keeping the runtime low. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #46593 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

These tests are a copy of the assert tests that verify the deep equal comparison algorithm. There is no need to duplicate the tests as changing one would require to change the tests in two places without knowing which ones to actually rely upon. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #46593 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

This is mainly a performance improvement for a lot of simple cases. Diverging elements are detected earlier and equal entries are partially also detected faster. A small correctness patch is also included where recursions now stop as soon as either side has a circular structure. Before, both sides had to have a circular structure at the specific comparison which could have caused more checks that likely fail at a later point. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #46593 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

This commit is there to be reverted after merging. It makes it easy to backport the overall PR and allows easy forward fixing. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #46593 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

chharvey · 2024-06-09T10:59:19Z

I believe this PR may have caused a regression from v18 to v20.

const x = ['x'];
assert.deepStrictEqual(new Set([x, ['y']]), new Set([x, ['y']]));

v18.20.2: pass — no error as expected
v20.0.0: fail — unexpected error:

AssertionError [ERR_ASSERTION]: Values have same structure but are not reference-equal:
Set(2) {
  [
    'x'
  ],
  [
    'y'
  ]
}

The bug seems to occur only when comparing Set objects, with a mix of elements where some elements are compared by reference (===) and other elements are compared by deep equality.

Looking at the changed code, a new "SafeSet" is created only containing the objects in a that are not in b, right? So this SafeSet only contains ['y']. But then on line 468, for (const val of b), every value of the b is checked, including the reference x, which causes the failure because the SafeSet does not contain it.

BridgeAR added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 9, 2023

nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Feb 9, 2023

BridgeAR changed the title ~~assert:util: improve comparison performance~~ assert,util: improve comparison performance Feb 9, 2023

BridgeAR added the needs-benchmark-ci PR that need a benchmark CI run. label Feb 9, 2023

anonrig added the performance Issues and PRs related to the performance of Node.js. label Feb 9, 2023

BridgeAR force-pushed the improve-comparison-performance branch 3 times, most recently from 588b4de to 64eb998 Compare February 10, 2023 02:39

anonrig approved these changes Feb 11, 2023

View reviewed changes

jasnell approved these changes Feb 11, 2023

View reviewed changes

mcollina approved these changes Feb 11, 2023

View reviewed changes

BridgeAR force-pushed the improve-comparison-performance branch from 64eb998 to c0a82bd Compare February 14, 2023 18:51

BridgeAR removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 14, 2023

BridgeAR force-pushed the improve-comparison-performance branch from c0a82bd to 13482c6 Compare February 14, 2023 23:06

mcollina approved these changes Feb 15, 2023

View reviewed changes

anonrig approved these changes Feb 16, 2023

View reviewed changes

BridgeAR added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 17, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 17, 2023

github-actions bot mentioned this pull request Feb 18, 2023

CI Reliability 2023-02-18 nodejs/reliability#499

Open

32 tasks

BridgeAR added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Feb 18, 2023

github-actions bot mentioned this pull request Feb 19, 2023

CI Reliability 2023-02-19 nodejs/reliability#500

Open

21 tasks

BridgeAR added commit-queue Add this label to land a pull request using GitHub Actions. assert Issues and PRs related to the assert subsystem. and removed needs-benchmark-ci PR that need a benchmark CI run. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 20, 2023

BridgeAR added 4 commits February 20, 2023 15:46

aduh95 force-pushed the improve-comparison-performance branch from 13482c6 to 575784b Compare February 20, 2023 14:47

aduh95 merged commit 575784b into nodejs:main Feb 20, 2023

juanarbol added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Mar 1, 2023

targos mentioned this pull request Mar 14, 2023

v19.8.0 release proposal #47087

Merged

This was referenced Jun 10, 2024

assert,crypto: make KeyObject and CryptoKey testable for equality #50897

Closed

deepStrictEqual fails for Sets that contain both object references and equivalent object values #53423

Closed

lemire mentioned this pull request Jun 12, 2024

assert,util: correct comparison when both contain same reference #53431

Merged

panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

assert,util: improve comparison performance #46593

assert,util: improve comparison performance #46593

BridgeAR commented Feb 9, 2023 •

edited

Loading

BridgeAR commented Feb 10, 2023

anonrig left a comment

mcollina left a comment

targos commented Feb 11, 2023

BridgeAR commented Feb 11, 2023 •

edited

Loading

BridgeAR commented Feb 14, 2023

mcollina left a comment

BridgeAR commented Feb 17, 2023

nodejs-github-bot commented Feb 17, 2023

nodejs-github-bot commented Feb 17, 2023

nodejs-github-bot commented Feb 17, 2023

nodejs-github-bot commented Feb 17, 2023

nodejs-github-bot commented Feb 18, 2023

BridgeAR commented Feb 20, 2023

targos commented Feb 20, 2023

BridgeAR commented Feb 20, 2023

aduh95 commented Feb 20, 2023

juanarbol commented Mar 1, 2023

chharvey commented Jun 9, 2024 •

edited

Loading

assert,util: improve comparison performance #46593

assert,util: improve comparison performance #46593

Conversation

BridgeAR commented Feb 9, 2023 • edited Loading

BridgeAR commented Feb 10, 2023

anonrig left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

targos commented Feb 11, 2023

BridgeAR commented Feb 11, 2023 • edited Loading

BridgeAR commented Feb 14, 2023

mcollina left a comment

Choose a reason for hiding this comment

BridgeAR commented Feb 17, 2023

nodejs-github-bot commented Feb 17, 2023

nodejs-github-bot commented Feb 17, 2023

nodejs-github-bot commented Feb 17, 2023

nodejs-github-bot commented Feb 17, 2023

nodejs-github-bot commented Feb 18, 2023

BridgeAR commented Feb 20, 2023

targos commented Feb 20, 2023

BridgeAR commented Feb 20, 2023

aduh95 commented Feb 20, 2023

juanarbol commented Mar 1, 2023

chharvey commented Jun 9, 2024 • edited Loading

BridgeAR commented Feb 9, 2023 •

edited

Loading

BridgeAR commented Feb 11, 2023 •

edited

Loading

chharvey commented Jun 9, 2024 •

edited

Loading