Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: dont access Object.prototype.type during TransformStream init #46389

Merged
merged 5 commits into from
Feb 2, 2023
+21 −0
Merged

stream: dont access Object.prototype.type during TransformStream init #46389

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2a828b
stream: dont access Object.prototype.type during TransformStream init
debadree25 Jan 28, 2023
0b29636
fixup!
debadree25 Jan 30, 2023
034f49f
fixup!
debadree25 Jan 30, 2023
efb65e0
fixup
debadree25 Jan 30, 2023
a8aa8a2
fixup! use configurable
debadree25 Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! use configurable
  • Loading branch information
@debadree25
debadree25 committed Jan 31, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit a8aa8a2bee23e556e0287a79a4dc66be8905f84e
3 changes: 2 additions & 1 deletion test/parallel/test-whatwg-transformstream.js
View file
Original file line number Diff line number Diff line change
@@ -191,6 +191,7 @@ class Source {
Object.defineProperty(Object.prototype, 'type', {
get: common.mustNotCall('get %Object.prototype%.type'),
set: common.mustNotCall('set %Object.prototype%.type'),
configurable: true,
});

new TransformStream({
@@ -202,5 +203,5 @@ class Source {
}
});

Reflect.deleteProperty(Object.prototype, 'type');
delete Object.prototype.type;
}