Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x] src: rename internal module declaration as internal bindings #46336

Closed
wants to merge 1 commit into from
Closed

[v18.x] src: rename internal module declaration as internal bindings #46336

wants to merge 1 commit into from

Commits on Jan 24, 2023

  1. src: rename internal module declaration as internal bindings 

    This is a continuation of the name reification on the internal bindings.

Renames NODE_MODULE_CONTEXT_AWARE_INTERNAL and
NODE_MODULE_EXTERNAL_REFERENCE to NODE_BINDING_CONTEXT_AWARE_INTERNAL
and NODE_BINDING_EXTERNAL_REFERENCE respectively.

PR-URL: nodejs#45551
Refs: nodejs#44036
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
    @legendecas
    legendecas committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    ee8b09b View commit details
    Browse the repository at this point in the history