-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update simdutf to 2.2.1 #46208
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Looks like instead of fixing the function naming/documentation for big endian (which I think would have been the better choice by far) simdutf decided to do a full breaking change and treat I guess this means that we'll need to add something like const auto simdutf_convert_utf8_to_utf16 = IsLittleEndian() ?
simdutf::convert_utf8_to_utf16le : simdutf::convert_utf8_to_utf16be; for all simdutf functions we intend to use and then use that instead. @anonrig Would you be up for adding functions to simdutf that just use host endianness, as one would expect for functions that take a |
Thanks for the mention @addaleax. I'll add this to simdutf. |
On a little-endian system, then the following test should pass... const char utf8source[] = "\xe7\x8c\xab";
char16_t u16output;
size_t u16len = simdutf::convert_utf8_to_utf16le(utf8source, 3, &u16output);
size_t u16len = simdutf::convert_utf8_to_utf16le(utf8source, 3, &u16output);
EXPECT_EQ(u16len, 1u);
EXPECT_EQ(u16output, 0x732B); On a big-endian system, you will need to replace the last line with... EXPECT_EQ(u16output, 0x2B73); (I understand that it is not what you want.) |
The simdutf PR is also a great idea. Go! |
When my pull request is merged, we can release a new version on |
Please consider release 3.0.0 which contains @anonrig's pull request. https://github.com/simdutf/simdutf/releases/tag/v3.0.0 |
I'll close this pull request, and wait for the github workflow to pick up the 3.0.0 release. Thanks everyone! |
This is an automated update of simdutf to 2.2.1.