Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 9.3.0 #46193

Merged
merged 2 commits into from
Jan 17, 2023
Merged

deps: upgrade npm to 9.3.0 #46193

merged 2 commits into from
Jan 17, 2023

Conversation

npm-cli-bot
Copy link
Contributor

9.3.0 (2023-01-12)

Features

Bug Fixes

Documentation

Dependencies

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jan 12, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@targos
Copy link
Member

targos commented Jan 13, 2023

@ljharb does npm/cli@cf175fb resolve your issue?

@ljharb
Copy link
Member

ljharb commented Jan 13, 2023

@targos no - that allows me to do npm --otp, which is a good bug fix, but if i do npm publish with no other config, i expect to be prompted for an OTP. npm 9 instead sends me to a web browser to do webauthn. My issue is that that "auth-type" change is breaking, on all extant node release lines.

@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 15, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 15, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46193
✔  Done loading data for nodejs/node/pull/46193
----------------------------------- PR info ------------------------------------
Title      deps: upgrade npm to 9.3.0 (#46193)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     npm-cli-bot:npm-v9.3.0 -> nodejs:main
Labels     npm, fast-track, needs-ci, dont-land-on-v14.x
Commits    1
 - deps: upgrade npm to 9.3.0
Committers 1
 - npm CLI robot 
PR-URL: https://github.com/nodejs/node/pull/46193
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: Jiawen Geng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46193
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: Jiawen Geng 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 12 Jan 2023 20:43:26 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46193#pullrequestreview-1247358228
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/46193#pullrequestreview-1247515683
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/46193#pullrequestreview-1249214145
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3923489114

@targos targos added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48992/

MylesBorins
MylesBorins approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2023
@MylesBorins
Copy link
Contributor

I pushed a change to ignore a file with known conflict markers in the npm test suite

@azu azu mentioned this pull request Jan 17, 2023
Closed
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48999/

Trott
Trott approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@Trott Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 17, 2023
@Trott
Copy link
Member

Trott commented Jan 17, 2023

@MylesBorins I added the label to squash the commits but if you want the commits to land separately, rebase to put your commit first.

@MylesBorins MylesBorins added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit 66b1356 into nodejs:main Jan 17, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 66b1356

Trott pushed a commit to Trott/io.js that referenced this pull request Jan 17, 2023
@npm-cli-bot @Trott
deps: upgrade npm to 9.3.0
77a87b5 
PR-URL: nodejs#46193
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott Trott mentioned this pull request Jan 17, 2023
Closed
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@npm-cli-bot @RafaelGSS
deps: upgrade npm to 9.3.0
c77186d 
PR-URL: nodejs#46193
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 18, 2023
@npm-cli-bot @MylesBorins
deps: upgrade npm to 9.3.0
679aae2 
PR-URL: #46193
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@npm-cli-bot @juanarbol
deps: upgrade npm to 9.3.0
5666b08 
PR-URL: #46193
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@npm-cli-bot @juanarbol
deps: upgrade npm to 9.3.0
7c03a3d 
PR-URL: #46193
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@npm-cli-bot @targos @ljharb @nodejs-github-bot @MylesBorins @Trott @lpinca @cjihrig @tniessen @gengjiawen