Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add automation for updating postject dependency #46157

Merged
merged 3 commits into from
Jan 14, 2023
Merged

tools: add automation for updating postject dependency #46157

merged 3 commits into from
Jan 14, 2023

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen [email protected]

cc @nodejs/single-executable

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jan 10, 2023
aduh95
aduh95 reviewed Jan 10, 2023
View reviewed changes
.github/workflows/tools.yml Outdated Show resolved Hide resolved
@RaisinTen RaisinTen added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 11, 2023
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 12, 2023
mhdawson
mhdawson approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@facutuesca if you have a change to review as well that would be good.

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jan 14, 2023
Open
19 tasks
@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 14, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 14, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48980/

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit d7d9811 into nodejs:main Jan 14, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d7d9811

@RaisinTen RaisinTen deleted the setup-updating-system-for-postject branch January 14, 2023 08:33
This was referenced Jan 15, 2023
Open
Open
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@RaisinTen @RafaelGSS
tools: add automation for updating postject dependency
eed4244 
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs#46157
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
This was referenced Jan 18, 2023
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@RaisinTen @RafaelGSS
tools: add automation for updating postject dependency
1aa4534 
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #46157
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@RaisinTen @juanarbol
tools: add automation for updating postject dependency
36f63d7 
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #46157
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@RaisinTen @juanarbol
tools: add automation for updating postject dependency
1b0cc79 
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #46157
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@tony-go tony-go mentioned this pull request Feb 3, 2023
Merged
@RaisinTen RaisinTen added the single-executable Issues and PRs related to single-executable applications label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tony-go tony-go tony-go approved these changes

@aduh95 aduh95 aduh95 approved these changes

@aymen94 aymen94 aymen94 approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project. single-executable Issues and PRs related to single-executable applications tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RaisinTen @nodejs-github-bot @mhdawson @aymen94 @aduh95 @tony-go