Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use process.hrtime.bigint instead of process.hrtime #45877

Merged
merged 2 commits into from
Jan 1, 2023
Merged

test: use process.hrtime.bigint instead of process.hrtime #45877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b0e8d6
test: use `process.hrtime.bigint` instead of `process.hrtime`
deokjinkim Dec 16, 2022
ecc7caa
Revise format of NS_PER_MS
deokjinkim Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions test/parallel/test-http2-session-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');
const hrtime = process.hrtime.bigint;
const NS_PER_MS = 1_000_000n;

let requests = 0;
const mustNotCall = () => {
Expand All @@ -14,7 +16,7 @@ const mustNotCall = () => {
const server = http2.createServer();
// Disable server timeout until first request. We will set the timeout based on
// how long the first request takes.
server.timeout = 0;
server.timeout = 0n;

server.on('request', (req, res) => res.end());
server.on('timeout', mustNotCall);
Expand All @@ -24,7 +26,7 @@ server.listen(0, common.mustCall(() => {

const url = `http://localhost:${port}`;
const client = http2.connect(url);
let startTime = process.hrtime();
let startTime = hrtime();
makeReq();

function makeReq() {
Expand All @@ -40,17 +42,17 @@ server.listen(0, common.mustCall(() => {
requests += 1;

request.on('end', () => {
const diff = process.hrtime(startTime);
const milliseconds = (diff[0] * 1e3 + diff[1] / 1e6);
if (server.timeout === 0) {
const diff = hrtime() - startTime;
const milliseconds = diff / NS_PER_MS;
if (server.timeout === 0n) {
// Set the timeout now. First connection will take significantly longer
// than subsequent connections, so using the duration of the first
// connection as the timeout should be robust. Double it anyway for good
// measure.
server.timeout = milliseconds * 2;
startTime = process.hrtime();
server.timeout = milliseconds * 2n;
startTime = hrtime();
makeReq();
} else if (milliseconds < server.timeout * 2) {
} else if (milliseconds < server.timeout * 2n) {
makeReq();
} else {
server.removeListener('timeout', mustNotCall);
Expand Down