Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] watch mode #44976

Closed
wants to merge 4 commits into from
Closed

[v16.x backport] watch mode #44976

wants to merge 4 commits into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Oct 12, 2022 •
edited
Loading

backport of
#44366
#44551
#44621
#44739

@nodejs-github-bot

This comment was marked as off-topic.

Sign in to view
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Oct 12, 2022
@MoLow MoLow added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Oct 12, 2022
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
@MoLow
cli: add --watch
cdb114e 
PR-URL: nodejs#44366
Backport-PR-URL: nodejs#44976
Fixes: nodejs#40429
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
@MoLow
test: split watch mode inspector tests to sequential
69c7a41 
PR-URL: nodejs#44551
Backport-PR-URL: nodejs#44976
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
@MoLow
test: deflake watch mode tests
09593b9 
PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
@MoLow
test: fix watch mode test flake
cd3a54f 
PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow MoLow marked this pull request as ready for review October 12, 2022 09:31
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
@MoLow
cli: add --watch
7c5ae65 
PR-URL: nodejs#44366
Backport-PR-URL: nodejs#44976
Fixes: nodejs#40429
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
@MoLow
test: split watch mode inspector tests to sequential
191eaec 
PR-URL: nodejs#44551
Backport-PR-URL: nodejs#44976
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
@MoLow
test: deflake watch mode tests
7de120a 
PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
@MoLow
test: fix watch mode test flake
72bf89e 
PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow
cli: add --watch
4c6ac5d 
PR-URL: nodejs#44366
Backport-PR-URL: nodejs#44976
Fixes: nodejs#40429
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MoLow
test: split watch mode inspector tests to sequential
880c48d 
PR-URL: nodejs#44551
Backport-PR-URL: nodejs#44976
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
@MoLow
test: deflake watch mode tests
fc94a10 
PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow
test: fix watch mode test flake
d8f559e 
PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2022
@nodejs-github-bot

This comment was marked as off-topic.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47250/

@mfranzke mfranzke mentioned this pull request Oct 13, 2022
Open
@MoLow MoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
@MoLow
Copy link
Member Author

MoLow commented Oct 29, 2022

@nodejs/releasers Hey, can this be merged in advance, a few days before the next node 16 release? #44873 depends on it

@MoLow MoLow mentioned this pull request Nov 23, 2022
Closed
richardlau pushed a commit that referenced this pull request Nov 23, 2022
@MoLow @richardlau
cli: add --watch
1e0dcd1 
PR-URL: #44366
Backport-PR-URL: #44976
Fixes: #40429
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
@MoLow @richardlau
test: split watch mode inspector tests to sequential
97f6caf 
PR-URL: #44551
Backport-PR-URL: #44976
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
@MoLow @richardlau
test: deflake watch mode tests
543d3d2 
PR-URL: #44621
Backport-PR-URL: #44976
Fixes: #44655
Reviewed-By: Benjamin Gruenbaum <[email protected]>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
@MoLow @richardlau
test: fix watch mode test flake
6d736a5 
PR-URL: #44739
Backport-PR-URL: #44976
Fixes: #44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@richardlau
Copy link
Member

Landed in 6f541d9...6d736a5

@richardlau richardlau closed this Nov 23, 2022
@MoLow MoLow deleted the backport-v16-watch-mode branch November 23, 2022 22:06
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
cli: add --watch
5cbcf30 
PR-URL: nodejs/node#44366
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#40429
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: split watch mode inspector tests to sequential
f9e84ab 
PR-URL: nodejs/node#44551
Backport-PR-URL: nodejs/node#44976
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: deflake watch mode tests
6636478 
PR-URL: nodejs/node#44621
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44655
Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: fix watch mode test flake
f2117be 
PR-URL: nodejs/node#44739
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
cli: add --watch
8631c77 
PR-URL: nodejs/node#44366
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#40429
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: split watch mode inspector tests to sequential
e4d5211 
PR-URL: nodejs/node#44551
Backport-PR-URL: nodejs/node#44976
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: deflake watch mode tests
f8bdc2e 
PR-URL: nodejs/node#44621
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44655
Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: fix watch mode test flake
fb703a7 
PR-URL: nodejs/node#44739
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@richardlau richardlau mentioned this pull request Jan 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

@JungMinu JungMinu JungMinu approved these changes

Assignees
No one assigned
Labels
commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MoLow @nodejs-github-bot @richardlau @JungMinu @danielleadams