Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add logs to watch-mode-inspect #44861

Merged
merged 1 commit into from
Oct 10, 2022
Merged

test: add logs to watch-mode-inspect #44861

merged 1 commit into from
Oct 10, 2022

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Oct 2, 2022

Refs: #44805

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 2, 2022
@MoLow MoLow added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 2, 2022
@MoLow
Copy link
Member Author

MoLow commented Oct 2, 2022

I have ran a stress test and the test was very stable, so the best assumption is this is related to ports or networking.
I suggest introducing this change making the logs appear so when there is a failure in the CI we can have more details

@MoLow MoLow marked this pull request as ready for review October 2, 2022 10:28
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47014/

@MoLow MoLow changed the title test: debug watch mode inspect flake test: add logs to watch-mode-inspect Oct 3, 2022
This was referenced Oct 6, 2022
Open
Open
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2022
@nodejs-github-bot nodejs-github-bot merged commit 0298b7f into nodejs:main Oct 10, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 0298b7f

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@MoLow @danielleadams
test: debug watch mode inspect
b9b671f 
PR-URL: #44861
Refs: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
@MoLow MoLow deleted the debug-watch-mode-flake branch October 12, 2022 08:48
@MoLow MoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErickWendel ErickWendel ErickWendel approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. watch-mode Issues and PRs related to watch mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MoLow @nodejs-github-bot @jasnell @benjamingr @ErickWendel