src: consolidate exit codes in the code base #44746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
ljharb
reviewed
Sep 22, 2022
aduh95
approved these changes
Sep 23, 2022
JakobJingleheimer
approved these changes
Sep 23, 2022
daeyeon
reviewed
Sep 23, 2022
Add an ExitCode enum class and use it throughout the code base instead of hard-coding the exit codes everywhere. At the moment, the exit codes used in many places do not actually conform to what the documentation describes. With the new enums (which are also available to the JS land as constants in an internal binding) we could migrate to a more consistent usage of the codes, and eventually expose the constants to the user land when they are stable enough.
joyeecheung
force-pushed
the
exit-codes
branch
from
dc81538
to
c49c504
Compare
joyeecheung
force-pushed
the
exit-codes
branch
from
c49c504
to
b439af8
Compare
16 tasks
This was referenced Sep 30, 2022
jasnell
approved these changes
Oct 2, 2022
9 tasks
16 tasks
19 tasks
|
Fixed the Windows failure @jasnell @Trott @aduh95 @JakobJingleheimer can you take a look again? Thanks! |
JakobJingleheimer
approved these changes
Oct 5, 2022
25 tasks
RaisinTen
reviewed
Oct 6, 2022
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in be525d7 |
This was referenced Oct 7, 2022
|
@joyeecheung do you mind backporting this to v18.x? It landed with conflicts. |
danielleadams
added
the
backport-requested-v18.x
|
From the results of
I'll see if I can prepare a PR with these |
debadree25
added a commit
to debadree25/node
that referenced
this pull request
Dec 13, 2022
debadree25
added a commit
to debadree25/node
that referenced
this pull request
Jan 3, 2023
debadree25
added a commit
to debadree25/node
that referenced
this pull request
Feb 19, 2023
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 26, 2023
Refs: #44746 PR-URL: #45841 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an ExitCode enum class and use it throughout the code base instead of hard-coding the exit codes everywhere. At the moment, the exit codes used in many places do not actually conform to what the documentation describes. With the new enums (which are also available to the JS land as constants in an internal binding) we could migrate to a more consistent usage of the codes, and eventually expose the constants to the user land when they are stable enough.